Use page 1 in the params #229

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant
@rhulse

rhulse commented Apr 18, 2012

When creating the pagination links, page 1 is not included for the links that go to page 1. This means that whatever is being paginated has to know that when no page param is set, it mean page one.

It is better form to explicitly set the page number all the time, ensuring that it will always work regardless of the underlying implementation.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Apr 18, 2012

amatsuda#222, We have the same thinking~

ghost commented Apr 18, 2012

amatsuda#222, We have the same thinking~

@rhulse

This comment has been minimized.

Show comment
Hide comment
@rhulse

rhulse Apr 18, 2012

I'll close this and go and +1 yours! :-)

rhulse commented Apr 18, 2012

I'll close this and go and +1 yours! :-)

@rhulse rhulse closed this Apr 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment