Add support for mongoid max_scan option #500

Merged
merged 1 commit into from Feb 1, 2014

Conversation

Projects
None yet
3 participants
@aptx4869
Contributor

aptx4869 commented Jan 26, 2014

Ignore specs when mongoid version is under 2.4
#495

Add support for mongoid max_scan option
respect the max_scan option in criteria

cache the total_count in the collection instance
prevent hitting db again in the same instance
@yuki24

This comment has been minimized.

Show comment Hide comment
@yuki24

yuki24 Jan 27, 2014

Member

Looks good, @amatsuda @zzak any thoughts? I think we can still merge this request at this point and work on extracting kaminari-mongoid later.

Member

yuki24 commented Jan 27, 2014

Looks good, @amatsuda @zzak any thoughts? I think we can still merge this request at this point and work on extracting kaminari-mongoid later.

@amatsuda

This comment has been minimized.

Show comment Hide comment
@amatsuda

amatsuda Feb 1, 2014

Member

👍

Member

amatsuda commented Feb 1, 2014

👍

yuki24 added a commit that referenced this pull request Feb 1, 2014

Merge pull request #500 from aptx4869/support-mongoid-max-scan
Add support for mongoid max_scan option

@yuki24 yuki24 merged commit cd90846 into kaminari:master Feb 1, 2014

1 check passed

default The Travis CI build passed
Details

@aptx4869 aptx4869 deleted the aptx4869:support-mongoid-max-scan branch Feb 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment