New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags for traces #327

Closed
thesamet opened this Issue Mar 22, 2016 · 2 comments

Comments

Projects
None yet
4 participants
@thesamet

thesamet commented Mar 22, 2016

Currently kamon.trace.withNewContext does not take any tags map, like kamon.metric.Counter does.

@ivantopo

This comment has been minimized.

Contributor

ivantopo commented Mar 30, 2016

hey @thesamet, thanks for reporting! We should also add it to the spray directives for tracing, see: https://groups.google.com/forum/#!topic/kamon-user/aU1pCISDGms

@sunnylbk

This comment has been minimized.

sunnylbk commented Mar 30, 2016

+1

dpsoft added a commit that referenced this issue Apr 1, 2016

@dpsoft dpsoft self-assigned this Apr 1, 2016

@dpsoft dpsoft added the In Progress label Apr 1, 2016

dpsoft added a commit that referenced this issue Apr 1, 2016

@dpsoft dpsoft closed this in 778c675 Apr 22, 2016

dpsoft added a commit that referenced this issue Apr 22, 2016

@ivantopo ivantopo removed the In Progress label Apr 22, 2016

dpsoft added a commit that referenced this issue Dec 4, 2016

dpsoft added a commit that referenced this issue Dec 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment