New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ kamon-elasticsearch: new integration module #309

Merged
merged 1 commit into from Mar 31, 2016

Conversation

Projects
None yet
2 participants
@jtjeferreira
Contributor

jtjeferreira commented Jan 23, 2016

This is a new module for elasticsearch integration, inspired on the jdbc module

segmentSnapshot.histogram("elapsed-time").get.numberOfMeasurements should be(100)
}
//

This comment has been minimized.

@dpsoft

dpsoft Feb 2, 2016

Contributor

@jtjeferreira please remove commented code.

Tracer.currentContext.finish()
}
val jdbcSnapshot = takeSnapshotOf("elasticsearch-requests", "elasticsearch-requests")

This comment has been minimized.

@dpsoft

dpsoft Feb 2, 2016

Contributor

@jtjeferreira please rename jdbc in variables names.

}
//
// "record the execution time of SLOW QUERIES based on the kamon.jdbc.slow-query-threshold" in {

This comment has been minimized.

@dpsoft

dpsoft Feb 2, 2016

Contributor

@jtjeferreira please remove commented code.

@dpsoft

This comment has been minimized.

Contributor

dpsoft commented Feb 2, 2016

@jtjeferreira the PR looks very good, please review the comments and I would like to merge it BUT there is one missing piece, not in this repository but in our documentation website! yes, I know, it is a bit boring to write docs but it is a necessary thing... so if you could create a simple one page doc explaining what this module does, how it reports data and possibly some screenshots of what kind of visualization or results you can get out of it would be super helpful even for us, to start experimenting with this :D.. take a look at the Datadog, StatsD and New Relic pages on our website to get an idea of what we would like to see there.

BTW: @ivantopo WDYT

@jtjeferreira

This comment has been minimized.

Contributor

jtjeferreira commented Mar 16, 2016

Hi. Sorry I missed these notifications somehow. I will fix the issues you mentioned and work in documentation...

@jtjeferreira jtjeferreira force-pushed the jtjeferreira:kamon-elasticsearch branch 2 times, most recently from 0d04e01 to c394832 Mar 17, 2016

@jtjeferreira jtjeferreira force-pushed the jtjeferreira:kamon-elasticsearch branch from c394832 to 273f2da Mar 17, 2016

@jtjeferreira

This comment has been minimized.

Contributor

jtjeferreira commented Mar 18, 2016

Hi @dpsoft and @ivantopo. I made the changes you requested.

Regarding the documentation, I am working on it although I have some questions. You serve it with github-pages and jekyll? I used the gem github-pages but if fails in the sitemap_generator.rb

@dpsoft

This comment has been minimized.

Contributor

dpsoft commented Mar 18, 2016

hi @jtjeferreira you should run jekyll serve --watch, and yes the sitemap-generator plugin have some issues... maybe disabling the plugin for a while can help you :(

@jtjeferreira

This comment has been minimized.

Contributor

jtjeferreira commented Mar 18, 2016

i have fixed the sitemap with jtjeferreira/kamon.io@fb0dfac and it works. I am now trying to write docs for both elastic and jdbc since they are very similar

@dpsoft

This comment has been minimized.

Contributor

dpsoft commented Mar 18, 2016

@jtjeferreira Amazing!!! and please include your fix for Jekyll :)

@jtjeferreira

This comment has been minimized.

Contributor

jtjeferreira commented Mar 30, 2016

Hi. Finally managed to write the documentation kamon-io/kamon.io#16

@dpsoft dpsoft merged commit 0d793ff into kamon-io:master Mar 31, 2016

@dpsoft

This comment has been minimized.

Contributor

dpsoft commented Mar 31, 2016

@jtjeferreira thanks for this PR!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment