New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in "normalize" strategy - add replace(":", "-") after replace(": ", "-") to cover the remotely deployed actors case #325

Merged
merged 2 commits into from Mar 29, 2016

Conversation

Projects
None yet
2 participants
@UriShohet

UriShohet commented Mar 20, 2016

Hi,

I have a cluster with a master and 2 slaves, and I couldn't see the metrics of the remotely deployed actors in the Grafana UI. I tried following what @ivantopo said in https://groups.google.com/forum/#!searchin/kamon-user/remote/kamon-user/OhF4opREL_0/m7ky1e80mfsJ but this didn't help, so I tried to change the normalize strategy and then I could finally see the metrics.

I hope this gets merged :-)

Remote actors paths look like
akka.tcp://ActorSystemName@Slavehost1:2551/remote/akka.tcp/ActorSystemName@Masterhost:2551/user/master/myRouter/c10

Before the change the remote actor's metrics didn't get through because
the ':' after the Masterhost and everything that followed it was cut off.
A metric name in grafana would look like
ActorSystemName.slavehost1.akka-actor.ActorSystemName_remote_akka_tcp_ActorSystemNameMasterhostIP,
now it looks like
ActorSystemName.slavehost1.akka-actor.ActorSystemName_remote_akka_tcp_ActorSystemNameMasterhostIP-2551_user_master_myRouter_c4.errors

Regards,
Uri

Shohet added some commits Mar 20, 2016

Shohet
in "normalize" strategy - replace ":" with "-", instead of ": " with "-"
Remote actors paths look like
akka.tcp://ActorSystemName@Slavehost1:2551/remote/akka.tcp/ActorSystemName@Masterhost:2551/user/master/myRouter/c10

Before the change the remote actor's metrics didn't get through because
the ':' after the Masterhost and everything that followed it was cut off.
A metric name in grafana would look like
ActorSystemName.slavehost1.akka-actor.ActorSystemName_remote_akka_tcp_ActorSystemNameMasterhostIP,
now it looks like
ActorSystemName.slavehost1.akka-actor.ActorSystemName_remote_akka_tcp_ActorSystemNameMasterhostIP-2551_user_master_myRouter_c4.errors
Shohet
revert to ": " to cover the "trace", "POST: /kamon/example" case, but…
… add replace(":", "-") afterwards to cover the remotely deployed actors case too

@UriShohet UriShohet changed the title from in "normalize" strategy - replace ":" with "-", instead of ": " with "-" to in "normalize" strategy - add replace(":", "-") after replace(": ", "-") Mar 21, 2016

@UriShohet

This comment has been minimized.

UriShohet commented Mar 21, 2016

I've realized that I've missed the "POST: /kamon/example" case, so I've added .replace(":", "-") after .replace(": ", "-") to cover the remotely deployed actors case

@UriShohet UriShohet changed the title from in "normalize" strategy - add replace(":", "-") after replace(": ", "-") to in "normalize" strategy - add replace(":", "-") after replace(": ", "-") to cover the remotely deployed actors case Mar 21, 2016

@ivantopo

This comment has been minimized.

Contributor

ivantopo commented Mar 28, 2016

hello @UriShohet, thanks for reporting AND fixing this issue :D, could you please electronically sign our CLA before we proceed to merge this PR? You can do so here: https://docs.google.com/forms/d/1G_IDrBTFzOMwHvhxfKRBwNtpRelSa_MZ6jecH8lpTlc/viewform

@UriShohet

This comment has been minimized.

UriShohet commented Mar 29, 2016

happy to have signed :-)

@ivantopo ivantopo merged commit dd1084f into kamon-io:master Mar 29, 2016

@ivantopo

This comment has been minimized.

Contributor

ivantopo commented Mar 29, 2016

thanks a lot @UriShohet! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment