+ core: support for regex path filters #388

Merged
merged 1 commit into from Nov 5, 2016

Projects

None yet

2 participants

@danbim
Contributor
danbim commented Aug 22, 2016

In my application I had a rather complicated use case where I had to exclude anonymous actors (created for Akka asks) from generating Kamon metrics. I found this very cumbersome to do based on the GlobPathFilter so I created this PR.

Putting it up here for discussion (e.g. to see if you're interested). Obviously some things are left to be done (e.g. end-user documentation).

@dpsoft dpsoft commented on the diff Aug 27, 2016
kamon-core/src/main/scala/kamon/util/PathFilter.scala
@@ -0,0 +1,5 @@
+package kamon.util
@dpsoft
dpsoft Aug 27, 2016 Contributor

@danbim please add the kamon copyright header.

@dpsoft
Contributor
dpsoft commented Aug 27, 2016 edited

@danbim the PR looks good for me, i've left a comment. I would like to merge it BUT there is one missing piece, not in this repository but in our documentation website! yes, I know, it is a bit boring to write docs but it is a necessary thing... so if you could change the filtering-entities documentation in oder to reflect this change it would be amazing.

@danbim
Contributor
danbim commented Sep 4, 2016

I'll update the docs soon!

@dpsoft dpsoft merged commit fd7cfb4 into kamon-io:master Nov 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dpsoft
Contributor
dpsoft commented Nov 5, 2016

@danbim thanks for proposing this PR!!!

@dpsoft dpsoft added this to the 0.6.4 milestone Nov 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment