New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand script paths that vim shortens in scriptnames report #3

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@cehoffman

cehoffman commented Jul 16, 2011

I'm not sure when in the console version of vim this started happening since I regularly use MacVim.

The output of scriptnames in the console version (7.3.237) has started to shorten the part of the path to the home directory as ~. This small change allows it to work in all versions of vim that I use currently, gui and console.

@nelstrom

This comment has been minimized.

Show comment
Hide comment
@nelstrom

nelstrom Jul 16, 2011

I was just trying to figure out why all of my custom text objects had stopped working. I applied your patch, and everything seems to work fine again. Thanks!

nelstrom commented Jul 16, 2011

I was just trying to figure out why all of my custom text objects had stopped working. I applied your patch, and everything seems to work fine again. Thanks!

@kana

This comment has been minimized.

Show comment
Hide comment
@kana

kana Jul 20, 2011

Owner

Thank you for reporting. As far as I know, the problem has appeared since 7.3.233. I'll review the problem and your commit later. (Because I don't have newer version of Vim to reproduce the problem yet)

Owner

kana commented Jul 20, 2011

Thank you for reporting. As far as I know, the problem has appeared since 7.3.233. I'll review the problem and your commit later. (Because I don't have newer version of Vim to reproduce the problem yet)

@kana

This comment has been minimized.

Show comment
Hide comment
@kana

kana Jul 20, 2011

Owner

I've reviewed the problem and cehoffman's commit. I'll upload fixed version to www.vim.org soon.

@cehoffman: Your commit is almost right, but there is a minor problem. What we really should do is to normalize script paths before comparison. But expand() is not proper for normalization because it is to expand wildcards, environment variables and others. We should use fnamemodify() instead.

Owner

kana commented Jul 20, 2011

I've reviewed the problem and cehoffman's commit. I'll upload fixed version to www.vim.org soon.

@cehoffman: Your commit is almost right, but there is a minor problem. What we really should do is to normalize script paths before comparison. But expand() is not proper for normalization because it is to expand wildcards, environment variables and others. We should use fnamemodify() instead.

@kana kana closed this Jul 20, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment