Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a interface for resize the canvas by the size of the documentElement.client size #312

Closed
zhoumeina opened this issue Oct 18, 2013 · 5 comments

Comments

@zhoumeina
Copy link

When the VM's VNC display is larger than the browser window we only can add scrollbars to the side of the screen. It would be much more user-friendly if we scaled the display to the window size so that the full desktop is always in view.Can we support it?

we need a interface to set the width and height of the RFB.

@samhed
Copy link
Member

samhed commented Oct 18, 2013

What exactly are you asking for? Scaling and re-sizing are different things.

A resize in this context would be triggered by the client, what is missing is support for the "ExtendedDesktopSize" encoding which is already present in the RFB protocol.
Support for this encoding is added in pull request #271 , I recently discovered a bug in that code which is why I have not merged it yet. You can always inspect my code in display.js and try to help me find what is wrong if you want.
#271 would not add a GUI option for this, if that is what you mean with "interface", but with the underlaying functionality there, GUI options would be simple.

Scaling would not require the actual VNC session to be resized, could be done entirely on the client side.

@ghost
Copy link

ghost commented Jun 9, 2014

I ran into this as well where the JS resized browser window was smaller than needed and was displaying scroll bars. This probably isn't a long term solution but adding to fb_width and fb_height where conf.onFBResize is called in rfb.js allowed me to increase the resized display enough to not have scroll bars in the browser.
ex: conf.onFBResize(that, fb_width + 16, fb_height + 18);

@DirectXMan12
Copy link
Member

closing due to no response.

@vishal-chhatwani
Copy link

Hello,

I am also facing the same issue where I want to set the dynamic width and height of the RFB but can't. By default it gets set to 800px by 480px. Did anyone find the solution?

@samhed
Copy link
Member

samhed commented Jan 9, 2019

@VishKumar I responded to your issue #1181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants