Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link button to text editor #4250

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@rafacamargo123
Copy link
Contributor

commented Jul 24, 2019

Add link button to text editor toolbar

@rafacamargo123

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

Behaviour:

If no text is selected, then it just adds a [title](http://...) to current cursor position and selects nothing:

ezgif-5-d5e550c52bc4

The title portion uses the internationalized string "Title".

If a text starting by http is selected, it will assume it's a link, so will populate the url portion of the markdown link with the selected text and select the "Title" portion so the user can change it:

ezgif-5-3e57c2766c29

If the selected text does not start with http, it's considered a title and the url portion is selected:

ezgif-5-d31f5aedd8b6

@fguillot fguillot merged commit 2bf0f99 into kanboard:master Jul 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@strukturart

This comment has been minimized.

Copy link

commented Jul 26, 2019

the safety starts with the little things ;-)
please add https:// as default protocol

@rafacamargo123 rafacamargo123 deleted the rafacamargo123:add-link-editor-button branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.