Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji support #15

Closed
jrgifford opened this issue Jan 25, 2013 · 9 comments
Closed

Emoji support #15

jrgifford opened this issue Jan 25, 2013 · 9 comments

Comments

@jrgifford
Copy link
Member

So, this is kind of a proposed enhancement:

Github and Campfire support Emoji - so :100: and :green_heart: read as 💯 and 💚, respectively. Lots of other options, full list is here.

Is this something we want to support in Kandan?

not a 1.0 thing, this is a potentially non-backwards compatible change.

@jrgifford
Copy link
Member Author

https://github.com/hassankhan/emojify.js looks like an easy way to implement basic support.

@jrgifford
Copy link
Member Author

we could also pass it through a rails helper. - https://github.com/github/gemoji

@kirantpatil
Copy link

+1 for "gemoji"

@fusion94
Copy link
Member

I think this would be something that get's bucketed under wishlist milestone until we get 1.0/1.1 out the door.

@sgrove
Copy link
Contributor

sgrove commented Jan 25, 2013

I'd recommend keeping as much client-side as possible, generally - we've
found it's considerably nicer for separating concerns, reasoning, and
ultimately porting app cleanly to different platforms when necessary.

On Fri, Jan 25, 2013 at 12:39 AM, Tony Guntharp notifications@github.comwrote:

I think this would be something that get's bucketed under wishlist
milestone until we get 1.0/1.1 out the door.


Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-12692288.

@jrgifford
Copy link
Member Author

Ok. Moving it to the backend also defeats the purpose of using something
like backbone.

James Gifford
cell: 2162238574

@jimmybrancaccio
Copy link

I'll +1 for gemoji. I was just about to post an issue for it, glad I looked first! 😄

@fusion94
Copy link
Member

@gabcen since you did emoticons do you think you can knock this out quickly?

@ghost ghost assigned gabceb Feb 22, 2013
@gabceb
Copy link
Member

gabceb commented Feb 22, 2013

If somebody can create a PR adding the emoticons to the list on https://github.com/kandanapp/kandan/blob/master/app/assets/javascripts/backbone/plugins/emoticons.js.coffee#L11. I can change the regex for it later. I am kind of busy with the admin stuff. Otherwise I can knock it out once I am done with admin

@gabceb gabceb closed this as completed in f875d9e Feb 22, 2013
ar7em pushed a commit to ar7em/kandan that referenced this issue Jun 9, 2013
Extended emoticon plugin to support emoji fixes kandanapp#15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants