New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename old compilers shortcuts for consistency with #1400 #1401

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
3 participants
@zloirock
Copy link
Collaborator

zloirock commented Jan 3, 2019

No description provided.

@ljharb

ljharb approved these changes Jan 3, 2019

Copy link
Collaborator

ljharb left a comment

Do we not have typescript targets that don't include core-js?

@zloirock

This comment has been minimized.

Copy link
Collaborator

zloirock commented Jan 3, 2019

@ljharb the builder generates tests for it (and for babel), but we haven't it in the table.

@zloirock zloirock merged commit b0080f7 into gh-pages Jan 3, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@zloirock zloirock deleted the rename-compilers branch Jan 3, 2019

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Jan 3, 2019

We should probably add them.

@zloirock

This comment has been minimized.

Copy link
Collaborator

zloirock commented Jan 3, 2019

I'm not sure about it. We have already too many columns for compilers. Features which require core-js have notes about it.

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Jan 3, 2019

Perhaps a redesign where things like babel, core-js, etc, can be toggled on or off on top of the basic runtime-less list?

Fair tho that as long as all the things that require the runtime have a note, it's fine - mainly thinking that we should find a way to have a single column for babel 6, and one for 7, and be able to pick a core-js version to apply on top of both (or none)

@zloirock

This comment has been minimized.

Copy link
Collaborator

zloirock commented Jan 3, 2019

Makes sense.

@kangax

This comment has been minimized.

Copy link
Owner

kangax commented Jan 3, 2019

Relatedly, sometimes I open compat table to find certain feature but don't remember part of which "year" it is. It'd be nice to redesign it in such a way that it was searchable without toggling ES revisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment