New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 74 Canary has Static Private Fields under flag #1415

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
3 participants
@chicoxyzzy
Copy link
Collaborator

chicoxyzzy commented Feb 1, 2019

No description provided.

@ljharb

ljharb approved these changes Feb 1, 2019

Copy link
Collaborator

ljharb left a comment

I would expect the entirety of the class fields proposal to be shipped under a flag; is this not the case?

@chicoxyzzy

This comment has been minimized.

Copy link
Collaborator Author

chicoxyzzy commented Feb 1, 2019

I would expect the entirety of the class fields proposal to be shipped under a flag; is this not the case?

I can't test in Chrome beta 73, but Chrome 72 doesn't have this feature even with --harmony flag

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Feb 1, 2019

I think maybe we should be testing these things before updating the results and not just relying on release announcements. Browsers claiming they have a feature has never been a reliable indicator that they built it right.

@chicoxyzzy

This comment has been minimized.

Copy link
Collaborator Author

chicoxyzzy commented Feb 1, 2019

I thought that we are already doing this... At least I do :) All results for class fields except Canary 74 look valid. I think that private static fields was added in Canary in one of latest patches after first 74 release. Although I could miss testing with --harmony flag for PR with Chrome 72 / Chrome 74 Canary releases, not sure TBH.
image

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Feb 1, 2019

ah i just misunderstood your comment :-)

@chicoxyzzy chicoxyzzy merged commit e3b8a3b into kangax:gh-pages Feb 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chicoxyzzy chicoxyzzy deleted the chicoxyzzy:ch_priv_stat_fields branch Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment