Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TemplateStrings bug test #1456

Merged
merged 2 commits into from May 7, 2019

Conversation

Projects
None yet
3 participants
@jridgewell
Copy link
Contributor

commented May 6, 2019

#1424 for context.

The Safari bug revealed that getStrings() !== new getStrings(), making
this easily testable. I've separated the original test into two:

  1. Test TemplateStrings call site revision
  2. Test the buggy Safari behavior explicitly

Is there some way to run old JS environments to see when the browsers changed behaviors?

Update TemplateStrings bug test
#1424 for context.

The Safari bug revealed that `getStrings() !== new getStrings()`, making
this easily testable. I've separated the original test into two:

1. Test TemplateStrings call site [revision](tc39/ecma262#890)
2. Test the buggy Safari behavior explicitly
@ljharb

ljharb approved these changes May 6, 2019

Copy link
Collaborator

left a comment

Clever!

@ljharb

This comment was marked as resolved.

Copy link
Collaborator

commented May 6, 2019

(you'll need an npm run build)

@jridgewell

This comment was marked as resolved.

Copy link
Contributor Author

commented May 6, 2019

Whoops, done.

@chicoxyzzy chicoxyzzy merged commit d547e31 into kangax:gh-pages May 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jridgewell jridgewell deleted the jridgewell:tagged-template-literals branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.