Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESNext] Add `Object` iteration proposal #1568

Merged
merged 1 commit into from Jan 9, 2020
Merged

[ESNext] Add `Object` iteration proposal #1568

merged 1 commit into from Jan 9, 2020

Conversation

@zloirock
Copy link
Collaborator

zloirock commented Jan 9, 2020

No description provided.

@zloirock zloirock force-pushed the object-iteration branch from 26d741b to b8d3a92 Jan 9, 2020
@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Jan 9, 2020

tbh it seems premature for a proposal earlier than stage 1 to have tests and any true values, since it’s not until stage 2 that the shape of the solution is finalized.

@zloirock

This comment has been minimized.

Copy link
Collaborator Author

zloirock commented Jan 9, 2020

Seems you forgot that compat-table contains tests for features from all stages, not only for 2+. Moreover, tests for stage 1 features more than others. It's the obvious behavior for proposed methods. If you wanna tests only for stable feature - it's test262.

@ljharb

This comment has been minimized.

Copy link
Collaborator

ljharb commented Jan 9, 2020

True; really what I'm suggesting is to remove tests for everything prior to stage 2 since they're utterly meaningless, but obviously then there'd be no point in the compat table listing stage < 2 proposals (which it probably shouldn't, but is a much larger discussion than this PR).

@ljharb ljharb force-pushed the object-iteration branch from b8d3a92 to 31905eb Jan 9, 2020
@ljharb
ljharb approved these changes Jan 9, 2020
@ljharb ljharb merged commit 673430d into gh-pages Jan 9, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ljharb ljharb deleted the object-iteration branch Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.