Skip to content

Added id attribute to all objects. #288

Closed
wants to merge 1 commit into from

2 participants

@bcoste
bcoste commented Oct 17, 2012

Added id attribute to all objects.

@bcoste bcoste Added id to all objects
Added id attribute to all objects.
a6e98b5
@kangax
Owner
kangax commented Oct 18, 2012

Thanks! Looks good. We also need to increment those ids when creating new objects. Similar to the way it's done in Raphael.js

@kangax
Owner
kangax commented Oct 28, 2012

On a second thought, the SVG-like id should probably be different from numeric UID. SVG-like id can be anything like "foo", "bar123", or "baz_xx_222". UID, on the other hand, should be strictly numeric and incremented for each object.

@kangax
Owner
kangax commented Dec 10, 2012

Will do a clean pull request.

@kangax kangax closed this Dec 10, 2012
@bcoste
bcoste commented Jan 21, 2013

We really needs SVG ids, could you please create the new pull request ?
I don't use UID, I don't understand why my simple solution hasn't been accepted ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.