Skip to content

ci: uniform Docker builds - #3430

Merged
yaleman merged 1 commit into
kanidm:masterfrom
JadedBlueEyes:ci-uniform-docker-builds
Feb 14, 2025
Merged

yaleman merged 1 commit into
kanidm:masterfrom
JadedBlueEyes:ci-uniform-docker-builds

Conversation

@JadedBlueEyes

Copy link
Copy Markdown
Contributor

Change summary

This is the first part of breaking down #3380, as suggested. It's a few small changes to the docker build pipelines. From the top:

  • Harden repo clones by setting persist-credentials: false as recommended by zizmor
  • Consistently use the same docker/metadata-action invocation for each pipeline
  • Apply labels & annotations from the metadata action
  • Instruct build to build from the locally cloned repo, instead of cloning a second time
  • Allow push job to run on forks
  • Use the lowercase repo name in the push job

Checklist

  • This PR contains no AI generated code
  • book chapter included (if relevant)
  • design document included (if relevant)

@CEbbinghaus CEbbinghaus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall. I'll let @yaleman chime in to approve.

Comment thread .github/workflows/docker_build_kanidm.yml
@yaleman
yaleman force-pushed the ci-uniform-docker-builds branch from 448c5e7 to a2e5628 Compare February 14, 2025 10:08
@yaleman
yaleman enabled auto-merge (squash) February 14, 2025 10:08
@yaleman
yaleman merged commit ce410f4 into kanidm:master Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants