Remaining fixes for Apple Silicon and QEMU #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed because in libucontext.h we include "libucontext/bits.h". We therefore need to have bits.h in somepath/libucontext/bits.h. In the Makefile, somepath/freestanding/bits.h was copied to the right path but in the meson build system, the include copy happens at the end.
_GNU_SOURCE can be defined without defining REG_X macros so it is not a good indicator. (QEMU for example defines it in the build system.) x86 and x86_64 should have consistant looking defs.h so ifndef guards are added to each REG_X definition.
Clang's arm64 assembler does not support multiple directives on a single line. C macros ALWAYS expand to a single line.
|
I still don't know of a good workaround for 9b1d8f0 the other way I considered is writing a Python script that generates the .S file but it seems like overkill. |
|
i think we can live with it for now. we should raise a bug with the clang project though to have this fixed: |
kaniini
approved these changes
Mar 9, 2021
|
I think having macros expand to a single line is standard but how assemblers handle newline alternative (like Seems like clang's arm64 assembler does not interpret |
|
yeah to be clear i was talking about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
These last couple of fixes are needed for the following