Commits on Sep 6, 2012
  1. @asanghi
  2. @asanghi
  3. @semaperepelitsa
  4. @aaronrenner
Commits on Sep 5, 2012
  1. @schneems

    Doc: sweepers only work on Active Record Models

    In response to this rails issue: rails/rails#3729
    schneems committed Sep 5, 2012
  2. @alup

    Fix a typo

    alup committed Sep 6, 2012
  3. @xoen

    Fixed array wrongly translated in footnote in a guide [ci skip]

    In the sentence "If <tt>@post.author_ids</tt> is [1], this would ..."
    the array [1] is converted in a footnote, fixed this using <notextile>.
    xoen committed Sep 5, 2012
  4. @radar

    Add giant belongs_to 'please don't pluralize me' note

    I've personally seen too many newbies get this wrong and pluralize the association
    radar committed Sep 5, 2012
Commits on Sep 4, 2012
  1. @rkh
Commits on Sep 3, 2012
  1. @guilleiguaran
  2. @gaurish

    Add section about tagged logging

    Tagged logging for which Rails has support since [3.2](http://guides.rubyonrails.org/3_2_release_notes.html#tagged-logging).
    It is trivial & useful but unless somebody explicitly searches API docs, he/she may not know about it. 
    
    Hence, I added it in guides. 
    gaurish committed Sep 3, 2012
  3. @andhapp
Commits on Sep 2, 2012
  1. @xoen

    Fixed validation issue and titles in Migrations guide [ci skip]

    Changed the title of the 3.5 chapter from "Using the change Method" to
    "When to Use the change Method" since the chapter tells the migration
    definitions supported by the change method. This fix the duplicate ID in the
    document.
    
    I've also changed some of the titles to respect the Guides guidelines.
    xoen committed Sep 2, 2012
  2. @xoen
  3. @xoen

    Fixed validation issues in the "Configuring Rails Applications" guide…

    … [ci skip]
    
    erb tag wasn't closed well
    xoen committed Sep 2, 2012
  4. @xoen
  5. @xoen
  6. @xoen

    Fixed validation issue in Upgrading Ruby on Rails guide [ci skip]

    In chapter 2.4 there was an underscore at the start of the attr_readonly method name,
    this underscore was interpreted as the opening of the <em> tag but it wasn't closed.
    
    Worst, the underscore in self.class.serialized_attributes (end of paragraph)
    was interpreted as the closing of the <em> tag and not as the name of a method.
    xoen committed Sep 2, 2012
Commits on Sep 1, 2012
  1. @vijaydev
  2. @vijaydev

    copy edits [ci skip]

    vijaydev committed Sep 1, 2012
  3. @fxn

    require bundle in the app generator

    The app generator is not generally run under bundler, but the Bundler
    constant is used here.
    
    In particular you cannot create --dev apps without this.
    fxn committed Sep 1, 2012
  4. @vijaydev

    Revert "added .DS_Store to .gitignore"

    This reverts commit fc80ebb.
    
    Such changes aren't allowed in docrails.
    vijaydev committed Sep 1, 2012
  5. @drogus

    Remove unneeded require

    drogus committed Sep 1, 2012
  6. @drogus

    Merge pull request #7494 from route/actionview_decoupling_issue

    ActionView decoupling and sprockets-rails tests fail
    drogus committed Sep 1, 2012
  7. @route

    Sprockets-rails tests fail

    Method invalid_asset_host! was delegated to controller but sprockets
    compile assets in their own scope without controller. And if we set asset_host
    with second parameter it should raise error through invalid_asset_host!.
    But since controller is nil it cannot be reached.
    route committed Sep 1, 2012
Commits on Aug 31, 2012
  1. @5v3n
  2. @drogus

    Require bundler 1.2

    drogus committed Aug 31, 2012
  3. @drogus

    Don't use Gemfile in test application in railties

    Option to run `bundle install` after generating new appplication was
    added recently to rails. Since introduction, it contained a subtle bug
    that caused it to use `Gemfile` from current directory (if it exists)
    rather than from generated directory. This also accidentaly caused
    railties tests to work without any problems - after generating test app
    it just used `Gemfile` from the repository, rather than the one in
    generated app. After fixing the bug mentioned above, this of course
    broke. The easiest way to bypass that is to not generate a `Gemfile` for
    test application - with such setup Bundler will just use first available
    `Gemfile` in one of the parent directories.
    drogus committed May 16, 2012
  4. @drogus
  5. @drogus

    Revert "Revert changes related to `bundle install` fixes in `rails new`"

    The cause of the previous revert was bug in bundler that made it hard to
    make railties test work. Fix for bundler was recently pushed to github,
    so now we can safely get back to the original commit.
    
    This reverts commit 0f5cc34.
    drogus committed Jun 25, 2012
  6. @steveklabnik

    Fix comment about Session.

    SessionHash isn't a thing, and tenses are wrong.
    steveklabnik committed Aug 31, 2012
  7. @lifo

    Fix my bio

    lifo committed Aug 31, 2012
  8. @jonleighton

    Avoid #fetch for non-nil values.

    This is purely a performance optimisation.
    
    See https://gist.github.com/3552829
    jonleighton committed Aug 31, 2012
  9. @jonleighton

    Key the attributes hash with symbols

    This is a performance/GC optimisation.
    
    In theory, this could be optimised by the implementation (last time I
    checked, this would have no effect on JRuby). But in practise, this make
    attribute access faster.
    jonleighton committed Aug 31, 2012
  10. @jonleighton