Make the output reproducible regardless of the system timezone #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the Reproducible Builds effort [0], I noticed that marked-man generates its output nondeterminstically if the value of SOURCE_DATE_EPOCH is within X hours of the end of the UTC month and the build system's timezone offset is greater than or equal to X hours. You can see an example here: https://bugs.debian.org/1030724#5 The solution is to emit the output as UTC and not in the build system's timezone. I originally filed this in Debian as bug #1030724 [1]. [0] https://reproducible-builds.org/ [1] https://bugs.debian.org/1030724
|
Hi Chris, thank you for this. |
|
According to my tests, the change you commited does not change it. As in, I tried that first. :) |
|
Ok, I'll add a test for this. |
|
Apparently my mistake is in the date option handling code. |
|
This time it should be ok |
|
Yep, this works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort, I noticed that marked-man generates its output nondeterministically if the value of
SOURCE_DATE_EPOCHis within X hours of the end of the UTC month and the build system's timezone offset is greater than or equal to X hours.You can see an example on the Debian bug.
The solution is to emit the output as UTC and not in the build system's timezone.