Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split parsers into serializers / deserializers #463

Closed
mensfeld opened this issue Jan 28, 2019 · 0 comments

Comments

@mensfeld
Copy link
Contributor

commented Jan 28, 2019

As @benissimo pointed out here: #461 parsers violate SRP and don't provide enough flexibility as the outgoing messages don't have to match the incoming type.

We should split it into two, replacing the parser with deserializer and leaving the serializer as it is, only to inject it by default into presenters. The rest will be updated by @benissimo and we can sync on that later.

We will also have to update docs.

@mensfeld mensfeld added this to the 1.3.0 milestone Jan 28, 2019

@mensfeld mensfeld self-assigned this Jan 28, 2019

@mensfeld mensfeld closed this Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.