Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: window customizations #11

Closed
krishnasajja opened this issue Sep 25, 2018 · 5 comments
Closed

Enhancement: window customizations #11

krishnasajja opened this issue Sep 25, 2018 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@krishnasajja
Copy link

Hi,
First of all, Thank you for this plugin. This is very simple and useful.

I was wondering if we can add some simple window customizations. Like if I want to see 'Hacker News' in the bigger window instead of Github.

Thanks!

@karakanb
Copy link
Owner

Hey, thanks for using it and providing feedback.

The next plan is to allow that, but I couldn't figure out a good way to implement that. As soon as I find out and make the time, I'll start working on it. For the time being, I am also very open to PRs that implement this functionality in any way.

@karakanb karakanb added the help wanted Extra attention is needed label Sep 25, 2018
@hipstersmoothie
Copy link
Contributor

It would be cool if you could make it arbitrary somehow and have thing like a twitter feed in there too

@karakanb
Copy link
Owner

Making it arbitrary seems to be a bold decision, it may increase the cognitive load for everyone, especially since this is a screen we see on every new page. The most primitive option is to treat the card titles as a dropdown menu and let the user select the content to be displayed there; the cards' placements will be considered fixed while the content itself can be updated.

@yochrepi
Copy link

yochrepi commented Nov 9, 2018

Hi,
First of all, Thank you for this plugin. This is very simple and useful.

I was wondering if we can add some simple window customizations. Like if I want to see 'Hacker News' in the bigger window instead of Github.

Thanks!

For example I wanted to see:

  1. Product hunt feed in the largest card on the left
  2. HN in the smaller card on right
  3. Github in the smaller card on right

In src/App.vue I changed the order of components:

from:

<div class="row cards-wrapper">
          <div class="col-lg-6 col-xs-10 col-xs-offset-1 col-lg-offset-0 left-pane">
            <git-hub></git-hub>
          </div>
          <div class="col-lg-6 col-xs-10 col-xs-offset-1 col-lg-offset-0">
            <div class="row" style="height: 39vh; margin-bottom: 1vh;">
              <hacker-news></hacker-news>
            </div>
            <div class="row" style="height: 40vh;">
              <product-hunt></product-hunt>
            </div>
          </div>
        </div>

to:

        <div class="row cards-wrapper">
          <div class="col-lg-6 col-xs-10 col-xs-offset-1 col-lg-offset-0 left-pane">
           <product-hunt></product-hunt>
          </div>
          <div class="col-lg-6 col-xs-10 col-xs-offset-1 col-lg-offset-0">
            <div class="row" style="height: 39vh; margin-bottom: 1vh;">
              <hacker-news></hacker-news>
            </div>
            <div class="row" style="height: 40vh;">
              <git-hub></git-hub>
            </div>
          </div>
        </div>

save, build and deploy :)

@karakanb
Copy link
Owner

karakanb commented May 5, 2019

Hey guys, I have built and published this functionality as v1.2.0. I have uploaded the release to Chrome Store which is already available right now, and I have also submitted the release for Firefox Add-Ons store. You can find detailed explanation in #19 which I have recently merged. I have implemented a dropdown in cards' titles in order to be able to change the platform shown in that card, and I have also introduced a couple of improvements to make adding new platforms easier in the future. Thanks for bearing with me, please let me know if there is anything I can do, I'll be closing the issue for now.

@karakanb karakanb closed this as completed May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants