Fix SysV pid_file to be consistent when ran from a differently named symlink #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…symlink SysV init scripts are ran on boot from symlinks in `/etc/rc.d/rc.X`, where X is the runlevel. These symlinks are usually named something like `S99foobar`, which is a link to the real script `foobar`. This leads to differences in the pid_file filename and can lead to multiple processes running. By using readlink to get the actual destination filename, the pid_file name should always be consistent. Resolves: kardianos#78
kardianos
approved these changes
Nov 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SysV init scripts are ran on boot from symlinks in
/etc/rc.d/rc.X, where X is the runlevel. These symlinks are usually named something likeS99foobar, which is a link to the real scriptfoobar. This leads to differences in the pid_file filename and can lead to multiple processes running. By using readlink to get the actual destination filename, the pid_file name should always be consistent.Resolves: #78