New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SysV pid_file to be consistent when ran from a differently named symlink #79

Merged
merged 1 commit into from Nov 4, 2016

Conversation

Projects
None yet
2 participants
@jessecarbon
Contributor

jessecarbon commented Nov 3, 2016

SysV init scripts are ran on boot from symlinks in /etc/rc.d/rc.X, where X is the runlevel. These symlinks are usually named something like S99foobar, which is a link to the real script foobar. This leads to differences in the pid_file filename and can lead to multiple processes running. By using readlink to get the actual destination filename, the pid_file name should always be consistent.

Resolves: #78

Fix SysV pid_file to be consistent when ran from a differently named …
…symlink

SysV init scripts are ran on boot from symlinks in `/etc/rc.d/rc.X`, where
X is the runlevel. These symlinks are usually named something like
`S99foobar`, which is a link to the real script `foobar`. This leads to
differences in the pid_file filename and can lead to multiple processes
running. By using readlink to get the actual destination filename, the
pid_file name should always be consistent.

Resolves: #78

@kardianos kardianos merged commit 6a55aec into kardianos:master Nov 4, 2016

@jessecarbon jessecarbon referenced this pull request Nov 4, 2016

Merged

Upgrade service version #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment