Add support for loading environment variables from optional file #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized that debian actually uses |
kardianos
approved these changes
Nov 19, 2016
|
Supporting debian would be nice. Please issue a PR when you get a chance. |
jessecarbon
added a commit
to jessecarbon/collector-sidecar
that referenced
this pull request
Dec 2, 2016
jessecarbon
added a commit
to jessecarbon/collector-sidecar
that referenced
this pull request
Dec 2, 2016
mariussturm
pushed a commit
to Graylog2/collector-sidecar
that referenced
this pull request
Dec 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common to want to load environment variables from an external file for a service upon startup. The common location for these for SysV scripts is
/etc/sysconfig/$service_name. Some examples: docker, Graylog, nginx, elasticsearch.For systemd unit files, there's an option called
EnvironmentFile. Example: elasticsearch.Both of these additions are only applied if the files exist. I've tested both of them on CentOS 6 and 7, respectively. The systemd
EnvironmentFilecan always be added after the fact with a drop-in, but i added it here for consistency. If it should be excluded, I can edit the PR. For SysV scripts however, there's not really another good way to inject environment variables.