Please sign in to comment.
hwclock: fix possible hang and other set_hardware_clock_exact() issues
In sys-utils/hwclock.c, set_hardware_clock_exact() has some problems when the process gets pre-empted (for more than 100ms) before reaching the time for which it waits: 1. The "continue" statement causes execution to skip the final tdiff assignment at the end of the do...while loop, leading to the while condition using the wrong value of tdiff, and thus always exiting the loop once newhwtime != sethwtime (e.g., after 1 second). This masks bug # 2, below. 2. The previously-existing bug is that because it starts over waiting for the desired time whenever two successive calls to gettimeofday() return values > 100ms apart, the loop will never terminate unless the process holds the CPU (without losing it for more than 100ms) for at least 500ms. This can happen on a heavily loaded machine or on a virtual machine (or on a heavily loaded virtual machine). This has been observed to occur, preventing a machine from completing the shutdown or reboot process due to a "hwclock --systohc" call in a shutdown script. The new implementation presented in this patch takes a somewhat different approach, intended to accomplish the same goals: It computes the desired target system time (at which the requested hardware clock time will be applied to the hardware clock), and waits for that time to arrive. If it misses the time (such as due to being pre-empted for too long), it recalculates the target time, and increases the tolerance (how late it can be relative to the target time, and still be "close enough". Thus, if all is well, the time will be set *very* precisely. On a machine where the hwclock process is repeatedly pre-empted, it will set the time as precisely as is possible under the conditions present on that particular machine. In any case, it will always terminate eventually (and pretty quickly); it will never hang forever. [email@example.com: - tiny coding style changes] Signed-off-by: Chris MacGregor <firstname.lastname@example.org> Signed-off-by: Karel Zak <email@example.com>
- Loading branch information...