Skip to content
Commits on Jun 24, 2016
  1. liblkid: Add length check in probe_nilfs2 before crc32

    The bytes variable is read from the file system to probe and must be
    checked before used as length parameter in the crc32 call.
    
    The following problems may occur here:
    
    - bytes smaller than sumoff + 4: underflow in length calculation
    - bytes larger than remaining space in sb: overflow of buffer
    
    This fixes a problem where an encrypted volume had the correct magic
    values 0x3434 at offset 0x406 and the following uint16_t (which is
    read into the nilfs_super_block.s_bytes struct) was parsed as 1.
    
    Then crc32 was called with the length value 18446744073709551597
    causing a segmentation fault.
    
    [kzak@redhat.com: - fix probe_nilfs2() return code]
    
    Signed-off-by: Karel Zak <kzak@redhat.com>
    Torsten Hilbrich committed with Jun 20, 2016
  2. lscpu: make lookup_cache() more robust

    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 24, 2016
  3. lscpu: fix MMHZ column entry within man page

    The indentation for the MMHZ column within the man page is wrong. Also
    there doesn't exist any column with the name MMHZ. The correct names
    would be MAXMHZ and MINMHZ.
    
    Therefore rename MMHZ to MAXMHZ and add the missong MINMHZ entry.
    
    Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
    Heiko Carstens committed with Jun 22, 2016
  4. lscpu: update s390-lpar-drawer testcase

    I noticed that the "cpu" line within /proc/cpuinfo has a different
    meaning on powerpc and sparc than on s390.
    
    On s390 it represents the cpu number while on powerpc and sparc it
    represent the model name. Given that the s390 kernel patch which adds
    the "cpu" line to /proc/cpuinfo hasn't been merged into the kernel
    yet, I changed that line to "cpu number" to avoid the unnecessary
    conflict.
    
    Therefore this patch updates the testcase, which mainly changes the
    contents of /proc/cpuinfo.
    
    Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
    Heiko Carstens committed with Jun 22, 2016
  5. lscpu: show additional caches (s390)

    The Linux kernel exposes the cache topology via sysfs. However on
    virtualized machines like s390 the cache topology contains only cpu
    private caches.
    
    For shared caches it is not known which cpus share them. The
    hypervisor would have to update this information whenever a virtual
    cpu would be scheduled on a different physical cpu and make the guest
    aware of that change. Given that there is hardly any benefit, if it
    all, this isn't done.
    
    However it is still of interest to know about the non-private
    caches. Therefore this information is available via /proc/cpuinfo at
    least on s390.
    
    This patch adds additional lines to the summary output for all shared
    caches for which information can be found in /proc/cpuinfo, since we
    know these aren't exposed via sysfs.
    
    Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
    Heiko Carstens committed with Jun 22, 2016
  6. lscpu: show machine type (s390)

    Show also the machine type within the lscpu output. With the machine
    type it is possible to identify the cpu generation and the supported
    features.
    
    Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
    Heiko Carstens committed with Jun 22, 2016
  7. lscpu: show static and dynamic MHz (s390)

    s390 machines provide static and dynamic cpu mhz information via
    /proc/cpuinfo. The static cpu mhz is the normal cpu frequency a cpu is
    supposed to run with.
    
    The dynamic cpu mhz is the actual frequency a cpu is running
    with. This is usually the same as the static cpu mhz. Note that this
    values are different to the min/max mhz values available on other
    architecutes. The min/max values are unknown.
    
    This patch adds two new fields to the summary output which display
    these two values.
    
    Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
    Heiko Carstens committed with Jun 22, 2016
  8. lscpu: fix typo in summary output

    The new drawer support did have a type in the summary output:
    it reported Drawers(s) instead of Drawer(s). Fix this.
    
    Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
    Heiko Carstens committed with Jun 22, 2016
  9. lscpu: add s390 drawer testcase

    Add a new s390 testcase so we get some coverage for the new drawer cpu
    topology level.
    
    Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
    Heiko Carstens committed with Jun 14, 2016
  10. lscpu: add drawer support

    The s390 architecture gained another cpu topology level called
    "drawer" which is above the book level.
    
    Add support for this to lscpu.
    
    Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
    Heiko Carstens committed with Jun 14, 2016
Commits on Jun 21, 2016
  1. libfdisk: cleanup fdisk_gpt_set_npartitions()

    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 21, 2016
  2. libfdisk: (gpt) be more careful with 64bit constants

    It's probably more robust (and readable) to be explicit when we count
    with constant and 64bit numbers.
    
    Addresses: http://bugzilla.redhat.com/show_bug.cgi?id=1344482
    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 21, 2016
  3. logger: be more precise about --port description

    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 21, 2016
Commits on Jun 14, 2016
  1. libblkid: don't check nonnull attributes for NULL [-Wnonnull-compare]

    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 14, 2016
  2. libmount: don't check nonnull attributes for NULL [-Wnonnull-compare]

    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 14, 2016
  3. chfn: chsh: use selinux_check_passwd_access()

    * selinux/av_permissions.h and magic constants are deprecated, the
      recommended solution is to use string_to_security_class() and
      string_to_av_perm() to get access vector
    
    * it also seems that selinux_check_passwd_access() does exactly the
      same as our checkAccess(), let's use it.
    
    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 14, 2016
Commits on Jun 9, 2016
  1. build-sys: remove global dependence between widechar and ncursesw

    It seems that globally defined dependence between ncursesw and
    wide-char support is overkill, because in some cases (e.g. cal(1)) we
    can use ncurses independently on wide-char support.
    
    It would be better to care about relation between wide-char and
    ncurses individually (per util).
    
    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 9, 2016
  2. tests: fix for non-ncurses version

    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 9, 2016
Commits on Jun 8, 2016
  1. build-sys: add non-action for ncurses pkg-cong test

    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 8, 2016
  2. build-sys: clean up relation between ncurses[w] and wide-char support

    * error if wide-char enabled/supported, but (non-wide) ncurses
      explicitly requested
    
    * disable ncurses at all if widechar enabled/supported, but ncursesw
      not found
    
    Reported-by: Stanislav Brabec <sbrabec@suse.cz>
    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 8, 2016
  3. build-sys: cleanup --with-ncurses

     * don't use UL_CHECK_LIB(), only use pkg-config to avoid complexity
    
     * split --with-ncursesw and --with-ncurses; ncurses (widechar) is the
       default, check for ncurses only if ncursesw disabled/unavailabled
    
     * don't use generic placeholders, just have_ncursesw and have_ncurses
    
    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 8, 2016
Commits on Jun 7, 2016
  1. @danielshahaf

    ionice: clarify description of --classdata

    Before this patch, it wasn't clear whether '0' or '7' should be used to
    specify "highest priority".  (The answer could have been inferred from
    the 'Examples' section of the man page.)
    
    Signed-off-by: Daniel Shahaf <danielsh@apache.org>
    danielshahaf committed with Jun 3, 2016
Commits on Jun 6, 2016
  1. build-sys: fix uClibc-ng scanf check

    uClibc-ng tries to be compatible with GNU libc and defines
    __GLIBC__ and pretend to be version 2.2.
    We once changed it to 2.10, but then some hard to fix problems
    in different software packages (gcc) occured.
    It would be better if we disable the special GNU libc checks
    for uClibc-ng here. uClibc-ng implements the required scanf
    functionality.
    
    Signed-off-by: Waldemar Brodkorb <wbx@uclibc-ng.org>
    Waldemar Brodkorb committed with Jun 3, 2016
Commits on Jun 3, 2016
  1. more: don't include ncurses.h, fix for non-widechar

    It seems our crazy widechar.h is in conflict with ncurses, but it
    seems that nothing in more.c requires anything from ncurses. All we
    need is probably <term.h>.
    
    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 3, 2016
  2. include/widechar: add fallback for WEOF

    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 3, 2016
  3. misc: cleanup non-widechar compilation

    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 3, 2016
  4. include/widechar: add missing fallbacks

    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 3, 2016
  5. build-sys: use UL_DEFAULT_ENABLE() only for programs

    The UL_DEFAULT_ENABLE modifies $enable_<name> according to the global
    --enable-all-programs. This makes sense only for programs, but not for
    any built-in code.
    
    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 3, 2016
  6. build-sys: add --disable-widechar

    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 3, 2016
  7. build-sys: add UL_REQUIRES_COMPILE macro

    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 3, 2016
  8. cfdisk: use libsmartcols ASCII for non-widechar environment

    Reported-by: Stanislav Brabec <sbrabec@suse.cz>
    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 3, 2016
  9. lib/mbsalign: fix for non-widechar

    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 3, 2016
  10. build-sys: fix comments in ul.m4

    Signed-off-by: Karel Zak <kzak@redhat.com>
    committed Jun 3, 2016
Something went wrong with that request. Please try again.