Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4 Support #10

Merged
merged 1 commit into from Sep 20, 2017

Conversation

Projects
None yet
2 participants
@banjun
Copy link
Contributor

commented Sep 20, 2017

IntMax seems to be deprecated in Swift 4.

StringParser.swift:73:69: error: 'IntMax' has been renamed to 'Int64'

Int64 should work with both Swift 3 & Swift 4.

Although all other parts remain in Swift 3 style (such as Package.swift), successful build in Swift 4 is helpful.

@kareman kareman merged commit d14bb3f into kareman:master Sep 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kareman

This comment has been minimized.

Copy link
Owner

commented Sep 20, 2017

Excellent work, thank you.

@banjun banjun deleted the banjun:swift4 branch Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.