New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added VERSION because EUM complains about not being able to set it #1

Merged
merged 1 commit into from Jan 31, 2015

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Jan 2, 2015

When running 'perl Makefile.PL' I got
WARNING: Setting VERSION via file 'lib/B/Hooks/EndOfScope.pm' failed
This PR adds the VERSION.

@karenetheridge

This comment has been minimized.

Show comment
Hide comment
@karenetheridge

karenetheridge Jan 2, 2015

Owner

Hi,
This change won't work on its own because the distribution is managed by Dist::Zilla, which automatically selects the next version based on git tags and adds the $VERSION statement into the built version of the dist.

There should be a way to solve the problem you describe, though (and there other things that could be improved in the dist) -- let's talk next week when I'm back from holidays, so do not fear!

Owner

karenetheridge commented Jan 2, 2015

Hi,
This change won't work on its own because the distribution is managed by Dist::Zilla, which automatically selects the next version based on git tags and adds the $VERSION statement into the built version of the dist.

There should be a way to solve the problem you describe, though (and there other things that could be improved in the dist) -- let's talk next week when I'm back from holidays, so do not fear!

@karenetheridge

This comment has been minimized.

Show comment
Hide comment
@karenetheridge

karenetheridge Jan 11, 2015

Owner

(edited from the original version sent by mail)

Hi, I'm back, sorry for the delay!

I can take this PR if you make a few changes:

  • the $VERSION should be for the next release, so change it to 0.14
  • add a $VERSION declaration to the other .pm files as well (all modules need versions)

And, add a few things to dist.ini:

  • in the [@Author::ETHER] section, add:
-remove = PkgVersion
-remove = Git::NextVersion

and then below that section (and above [Prereqs]), add:

[RewriteVersion]
[BumpVersionAfterRelease]
[Git::Commit / bumped $VERSION after release]
allow_dirty_match = ^lib
commit_msg = After release: bump $VERSION
[Git::Push / push $VERSION bump]

These changes will make Dist::Zilla take the distribution version from the
.pm, rather than git tags, and also cause it to increment the version in the
.pm after release, and then commit the change to git.

Owner

karenetheridge commented Jan 11, 2015

(edited from the original version sent by mail)

Hi, I'm back, sorry for the delay!

I can take this PR if you make a few changes:

  • the $VERSION should be for the next release, so change it to 0.14
  • add a $VERSION declaration to the other .pm files as well (all modules need versions)

And, add a few things to dist.ini:

  • in the [@Author::ETHER] section, add:
-remove = PkgVersion
-remove = Git::NextVersion

and then below that section (and above [Prereqs]), add:

[RewriteVersion]
[BumpVersionAfterRelease]
[Git::Commit / bumped $VERSION after release]
allow_dirty_match = ^lib
commit_msg = After release: bump $VERSION
[Git::Push / push $VERSION bump]

These changes will make Dist::Zilla take the distribution version from the
.pm, rather than git tags, and also cause it to increment the version in the
.pm after release, and then commit the change to git.

@karenetheridge

This comment has been minimized.

Show comment
Hide comment
@karenetheridge

karenetheridge Jan 30, 2015

Owner

hi, are you still alive? the month is almost over! :)

Owner

karenetheridge commented Jan 30, 2015

hi, are you still alive? the month is almost over! :)

karenetheridge added a commit that referenced this pull request Jan 31, 2015

Merge pull request #1 from simonaw/master
added VERSION because EUM complains about not being able to set it

@karenetheridge karenetheridge merged commit 9f64ca8 into karenetheridge:master Jan 31, 2015

@karenetheridge

This comment has been minimized.

Show comment
Hide comment
@karenetheridge

karenetheridge Jan 31, 2015

Owner

ok, I can take this PR as-is and then make amendments on top, so you'll still get credit for January!

Owner

karenetheridge commented Jan 31, 2015

ok, I can take this PR as-is and then make amendments on top, so you'll still get credit for January!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment