New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EUM and Dist::Zilla changes #2

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Feb 1, 2015

Karen,

sorry, sorry, sorry for the delay. Unfortunately I got a little bit too busy in the last weeks what was actually not planned so that I almost forgot about this. I know, I need to get better in time management. I hope you're still in for discussing another PR (although it's already February):

  • added $VERSION to the other modules
  • changed dist.ini as proposed

So now I added $VERSION to all of the modules and altered the dist.ini as well.

That now leads to [DZ] attempted to set version twice when running dzil build although I added -remove = PkgVersion and -remove Git::NextVersion to the dist.ini -- and -- I guess is exactly what you anticipated when declining my first PR, right?

So is there actually an either Dist::Zilla or EUM but not both?

Simon Wilper
EUM and Dist::Zilla changes
- added $VERSION to the other modules
- changed dist.ini as proposed
@karenetheridge

This comment has been minimized.

Show comment
Hide comment
@karenetheridge

karenetheridge Feb 1, 2015

Owner

You're a bit late -- check out the release that went out yesterday!

Don't worry, neilb has you marked down as "complete" for January :)

Owner

karenetheridge commented Feb 1, 2015

You're a bit late -- check out the release that went out yesterday!

Don't worry, neilb has you marked down as "complete" for January :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment