Skip tests removed from Module::CPANTS::Analyse #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the metrics will be removed (or moved to Module::CPANTS::SiteKwalitee) in the near future when the next version of Module::CPANTS::Analyse is released. This patch checks which tests are done and skips the rest in the end. Or, you might want to declare the number of tests that actually remain in Module::CPANTS::Analyse/Kwalitee. Whichever is ok, as long as the number of the tests is correctly handled.
|
thanks for the reminder that I need to handle what metrics are available... I'd started some refactoring last month to handle this, and then got sidetracked.. will revisit in the next few days. |
|
I'd rather not hardcode the list of test names at all -- what can I call in Module::CPANTS::Analyse to get the current list? |
|
version 1.08 does not hardcode tests, which allows MCA to change the list of metrics more easily. A request to add conflict data has been submitted at https://rt.cpan.org/Ticket/Display.html?id=86952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the metrics will be removed (or moved to Module::CPANTS::SiteKwalitee) in the near future when the next version of Module::CPANTS::Analyse is released. This patch checks which tests are done and skips the rest in the end.
Or, you might want to declare the number of tests that actually remain in Module::CPANTS::Analyse/Kwalitee. Whichever is ok, as long as the number of the tests is correctly handled.