Join GitHub today
Automated tests. #15
This goes a long way to solve #5: now we have a script that does all the tests, all we need is find the best DOM normalizer to compare DOM trees.
Detailed diagnosis for a single engine
Sample output for a single error:
Configurations can be done under
This is currently using Beautiful Soup 4
As far as I can tell there are two problems with BS4:
Still I think this is already useful on its own.
If anyone finds a better normalizer, you just have to modify one method:
@karlcow I tried
I don't know if in HTML DOM multiple spaces / newlines are all equivalent in the specs and implementations.
This SO question asks that.
About the logging, I started doing it after you told be about it, but then I noticed that there are only two kinds of things being printed:
The only advantage I can see of logging in this case would be to standardize error prefix, but that could be done with a string variable. Is there something else? Or are you mostly looking ahead?
I'll definitely implement it, just trying to understand the rationale before so I do things right. =)
Asked on Stack Overflow about DOM comparison: http://stackoverflow.com/questions/22687455/compare-two-html-documents-normalizing-multiple-and-trailing-whitespaces
This was referenced
Mar 28, 2014
@cirosantilli I will merge this one, but for next time.
I guess it's time to add a CONTRIBUTING.md :)