New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list-code-1-space test. #34

Merged
merged 6 commits into from Apr 25, 2014

Conversation

Projects
None yet
2 participants
@cirosantilli
Contributor

cirosantilli commented Apr 23, 2014

The question is: what happens when there is a code block inside a list which starts with - a, and not - a?

Running ./run-tests.py -as list-code-1 tells me all engines do the sane thing and pass this test...
except for Marked and Kramdown 😠 , which add two spaces:

<code>  b

thus completely breaking my web page =(

It seems however clear from the spec that:

To put a code block within a list item, the code block needs to be indented twice — 8 spaces or two tabs:

Unfortunately all given examples are of type - a, so maybe this is why the problem happens.

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Apr 24, 2014

Kramdown said WONTFIX even for an option that alters this behavior, but would probably consider a pull request under --input gfm.

Marked already has an option to be pedantic for all behavior, and it may consider an option to alter only this behavior.

karlcow added a commit that referenced this pull request Apr 25, 2014

@karlcow karlcow merged commit 985bf2d into karlcow:master Apr 25, 2014

@cirosantilli cirosantilli deleted the cirosantilli:list-code-1-space branch Apr 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment