New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ordered-list-inner-par-list test. #40

Merged
merged 1 commit into from Apr 29, 2014

Conversation

Projects
None yet
2 participants
@cirosantilli
Contributor

cirosantilli commented Apr 29, 2014

./run-tests.py -as list-inner-par-l tells me that only Redcarpet and GitHub break this.

Redcarpet's break might be acceptable: ./run-tests.py -s list-inner-par-l redcarpet says that the first li does not get a paragraph:

Normalized actual / expected:
u'<ol><li>1</li></ol><pre><code>- inner par list\n</code></pre><ol><li>2</li></ol>'
u'<ol><li><p>1</p><ul><li>inner par list</li></ul></li><li><p>2</p></li></ol>'

IMHO GFM's break is not acceptable: ./run-tests.py -s list-inner-par-l gfm shows how it generates two ordered lists:

Normalized actual / expected:
u'<ol><li><p>1</p><ul><li>inner par list</li></ul></li></ol><ol><li>2</li></ol>'
u'<ol><li><p>1</p><ul><li>inner par list</li></ul></li><li><p>2</p></li></ol>'

GFM is the reason I'm adding this test. I have reported this as a bug at: isaacs/github#181

@karlcow

This comment has been minimized.

Owner

karlcow commented Apr 29, 2014

sounds good indeed.

karlcow added a commit that referenced this pull request Apr 29, 2014

@karlcow karlcow merged commit e9a8e31 into karlcow:master Apr 29, 2014

@cirosantilli cirosantilli deleted the cirosantilli:ordered-list-inner-par-list branch May 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment