New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run multimarkdown in compatibility mode. #60

Merged
merged 1 commit into from Sep 4, 2014

Conversation

Projects
None yet
3 participants
@cirosantilli
Contributor

cirosantilli commented Jul 10, 2014

Falls to one error, since other existing "errors" were alternative good outputs that were hard to normalize.

@fletcher

This comment has been minimized.

fletcher commented Jul 15, 2014

Actually, if you use the latest version there are no failures. ;)

(And on my machines it seems to run neck-and-neck with hoedown for fastest performance in admittedly unscientific testing.)

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Jul 15, 2014

Weird, I retried now, and with the compatibility flag -c it runs like howedown, without it "fails" more, e.g. figure element on images, like before. You don't reproduce? We are both talking about https://github.com/fletcher/MultiMarkdown-4 master right?

@fletcher

This comment has been minimized.

fletcher commented Jul 15, 2014

With -c it should pass all tests.

Without -c, it should "fail" some because the tests are wrong. They
test Markdown, not MultiMarkdown.

On 7/15/14, 9:34 AM, Ciro Santilli wrote:

Weird, I retried now, and with the compatibility flag |-c| it runs like
howedown, without it "fails" more, e.g. |figure| element on images. You
don't reproduce? We are both talking about
https://github.com/fletcher/MultiMarkdown-4 master right?


Reply to this email directly or view it on GitHub
#60 (comment).

Fletcher T. Penney
fletcher@fletcherpenney.net

@cirosantilli

This comment has been minimized.

Contributor

cirosantilli commented Jul 15, 2014

Ah, OK, what you meant is that you've fixed the single error with -c on master which hoedown also has. Awesome!

@fletcher

This comment has been minimized.

fletcher commented Jul 15, 2014

Correct. MMD in "regular" mode should not pass the other tests, since they are "wrong" in that context.

karlcow added a commit that referenced this pull request Sep 4, 2014

Merge pull request #60 from cirosantilli/multimarkdown-compat
Run multimarkdown in compatibility mode.

@karlcow karlcow merged commit a05eeb2 into karlcow:master Sep 4, 2014

@karlcow

This comment has been minimized.

Owner

karlcow commented Sep 4, 2014

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment