Permalink
Commits on Sep 12, 2012
  1. Set the value for the failing attribute

    drapergeek authored and Gabe Berke-Williams committed Aug 7, 2012
  2. WIP: Fix positve error description spec issues and add method for mat…

    drapergeek authored and Gabe Berke-Williams committed Jul 20, 2012
    …ched_error.
  3. WIP: Positive error description

    Gabe Berke-Williams
    Gabe Berke-Williams committed May 30, 2012
    Currently AllowValueMatcher has a commented-out example usage, which should be
    uncommented when this is ready.
    
    Ideally the `if expected_message` nil-check in AllowValueMatcher will be handled
    by PositiveErrorDescription too.
    
    Use it in FormattedErrorDescription as well.
    
    We use PositiveErrorDescription#matches? and #matched_error to grab the
    description and return the correct thing in FormattedErrorDescription. I
    envision FormattedErrorDescription being used in AllowValueMatcher too, probably
    with a #matches? method too that delegates.
  4. WIP-WIP-WIP: extract formatted error message to a third class

    Gabe Berke-Williams
    Gabe Berke-Williams committed May 25, 2012
    Currently Dis/allowValueMatcher uses the mixed-in pretty_error_messages method.
    Since DisallowValueMatcher isn't a perfect logical inverse of AllowValueMatcher,
    we need to have a third class that handles error messages for us.
    
    Future thoughts:
    
    Have a PositiveErrorDescription and a NegativeErrorDescription, which will
    compose FormattedErrorMessageList into a "Did not expect errors, got errors: "
    vs "Expected errors, got no errors". Idea: one of them can decorate the other
    and return the other's negative message as its positive message and vice versa.
  5. Ensure generation of test rails app succeeds.

    Gabe Berke-Williams
    Gabe Berke-Williams committed May 25, 2012
  6. All specs passing. Cucumber fails.

    Gabe Berke-Williams
    Gabe Berke-Williams committed May 25, 2012
  7. Passing tests for WithMessageMatcher.

    Gabe Berke-Williams
    Gabe Berke-Williams committed May 25, 2012
  8. Correctly disambiguate class name.

    Gabe Berke-Williams
    Gabe Berke-Williams committed May 25, 2012
  9. Typo.

    Gabe Berke-Williams
    Gabe Berke-Williams committed May 25, 2012
  10. Test pretty_error_messages.

    Gabe Berke-Williams
    Gabe Berke-Williams committed May 25, 2012
  11. Test for the correct thing.

    Gabe Berke-Williams
    Gabe Berke-Williams committed May 25, 2012
  12. Whitespace.

    Gabe Berke-Williams
    Gabe Berke-Williams committed May 25, 2012
  13. Refer to fully-qualified class name.

    Gabe Berke-Williams
    Gabe Berke-Williams committed May 25, 2012
  14. Allow bundler 1.2.0.pre.

    Gabe Berke-Williams
    Gabe Berke-Williams committed May 25, 2012
  15. fix a few broken tests after changing the design of CompositeMatcher

    drapergeek authored and Gabe Berke-Williams committed May 25, 2012
  16. A bit of cleanup.

    Gabe Berke-Williams
    Gabe Berke-Williams committed May 21, 2012
  17. WIP: refactor shoulda matchers

    drapergeek authored and Gabe Berke-Williams committed May 21, 2012
  18. WIP: refactor shoulda matchers

    drapergeek authored and Gabe Berke-Williams committed May 21, 2012
  19. move with message matcher into seperate file and fix issue with nil m…

    drapergeek authored and Gabe Berke-Williams committed May 18, 2012
    …essage
  20. Add tests for CompositeMatcher.

    Gabe Berke-Williams
    Gabe Berke-Williams committed May 17, 2012
  21. WIP: start using composite pattern.

    drapergeek authored and Gabe Berke-Williams committed May 17, 2012
Commits on Aug 30, 2012
  1. Bump version to 1.3.0

    joshuaclayton committed Aug 30, 2012
Commits on Aug 14, 2012
  1. Merge pull request thoughtbot#140

    fabiokr authored and gylaz committed Jul 4, 2012
    * Allows to use the validate_format_of matcher with allow_blank and allow_nil options
    * Fixup test descriptions
    * Remove duplicate entry from news
Commits on Jul 27, 2012
  1. Merge pull request thoughtbot#136 from potomak/patch-1

    Gabe Berke-Williams
    Gabe Berke-Williams committed Jul 27, 2012
    Remove duplicate spec; add in_array
  2. Merge pull request thoughtbot#136 from potomak/patch-1

    Gabe Berke-Williams
    Gabe Berke-Williams committed Jul 27, 2012
    Remove duplicate spec; add in_array
Commits on Jul 25, 2012
Commits on Jul 20, 2012
  1. Update NEWS file.

    Gabe Berke-Williams
    Gabe Berke-Williams committed Jul 20, 2012
  2. Removed old Rails 2.x layout lookup.

    elliterate authored and Gabe Berke-Williams committed Jun 28, 2012
    Fixes render_with_layout matcher when rendering with only a partial.
    (Rendering with :layout => false would also have had this problem on
    Edge Rails.)
  3. Update NEWS file.

    Gabe Berke-Williams
    Gabe Berke-Williams committed Jul 20, 2012
Commits on Jul 11, 2012
  1. Mix RSpec with Test::Unit

    mike-burns committed Jul 11, 2012
    An edge case occurs when mixing RSpec and Test::Unit tests and also
    loading both the 'rspec-rails' gem and 'shoulda-matchers' gem from the
    same Gemfile group, namely [:test, :development] . Work around this by
    always inserting the shoulda matchers into Test::Unit, regardless of
    whether RSpec is loaded.
Commits on Jul 10, 2012
Commits on Jul 9, 2012
  1. Restore uniqueness scope values after verifying each scope.

    elliterate authored and mike-burns committed Jun 28, 2012
    A test for a validation with multiple scopes would always pass as long
    as there was a validation with the first scope. Subsequent scopes would
    pass verification because the first scope value had already been made
    unique.