Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to find only 'Jenkins' in the login page #59

Merged
merged 5 commits into from Jun 25, 2018

Conversation

@haidaraM
Copy link
Contributor

haidaraM commented Jun 20, 2018

Jenkins changed its login page template in 2.128 (https://issues.jenkins-ci.org/browse/JENKINS-50447).
The Jenkins version is no longer in the login page so the role fails with the most recent version of Jenkins.

Mohamed El Mouctar HAIDARA and others added 3 commits Jun 20, 2018
Jenkins changed its login page template in 2.128 (https://issues.jenkins-ci.org/browse/JENKINS-50447).
The Jenkins version is no longer in the login page so the role fails with the most recent version of Jenkins.
Last attempt didn't seem to actually run the debug task in Travis? No
idea why...
@haidaraM

This comment has been minimized.

Copy link
Contributor Author

haidaraM commented Jun 25, 2018

Hmm that's strange... Cannot see why travis fails

karlmdavis added 2 commits Jun 25, 2018
Not sure why the previous form wouldn't work, but maybe this form
will...
I was being a dumb-dumb: the **first** verify task was passing. What I
was seeing being marked as failing was actually the **second** one,
which hadn't been fixed by the original patch. Reading comprehension
fail on my part.
@karlmdavis

This comment has been minimized.

Copy link
Owner

karlmdavis commented Jun 25, 2018

Yeah, I had trouble figuring it out, too. Turns out there are two of those checks in the test: one built-in to the role, and another that's part of the test_basic.yml test itself. Fixed it.

@karlmdavis karlmdavis merged commit 8b5d2dd into karlmdavis:master Jun 25, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@karlmdavis

This comment has been minimized.

Copy link
Owner

karlmdavis commented Jun 25, 2018

Thanks for the fix!

Included in release: https://github.com/karlmdavis/ansible-role-jenkins2/releases/tag/v3.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.