Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setters to IOhlcv #50

Closed
pahlot opened this issue May 28, 2018 · 3 comments
Closed

Add setters to IOhlcv #50

pahlot opened this issue May 28, 2018 · 3 comments

Comments

@pahlot
Copy link
Contributor

pahlot commented May 28, 2018

While the current design makes sense to some degree, the fact that there are no setters outside of the constructor limits the ability to serialize/de-serialize instances that inherit from IOhlcv, this especially an issue when passing instances that inherit from IOhlcv via a message bus.

@karlwancl
Copy link
Owner

@pahlot, ya, giving setter to IOhlcv properties actually provide better extensibility on it. It would be good if you could help creating PR for it. Thanks.

@pahlot
Copy link
Contributor Author

pahlot commented May 29, 2018

@lppkarl done :)

@karlwancl
Copy link
Owner

The beta2 package on this change has been uploaded to nuget. Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants