From 695a13fe6fbc4a003dfdb01b04d52d317533ac85 Mon Sep 17 00:00:00 2001 From: L42y <423300@gmail.com> Date: Sat, 10 Aug 2013 22:05:42 +0800 Subject: [PATCH] feat: add device option --- README.md | 9 ++++++++- index.js | 3 ++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 447168a..247f88d 100644 --- a/README.md +++ b/README.md @@ -45,10 +45,16 @@ module.exports = function(config) { browser: 'firefox', os: 'mac', version: '21.0' + }, + bs_iphone5: { + base: 'BrowserStack', + device: 'iPhone 5', + os: 'ios', + version: '6.0' } }, - browsers: ['bs_firefox_mac'] + browsers: ['bs_firefox_mac', 'bs_iphone5'] }); }; ``` @@ -60,6 +66,7 @@ module.exports = function(config) { ### Per browser options +- `device` name of the device - `browser` name of the browser - `version` version of the browser - `os` which platform ? diff --git a/index.js b/index.js index a59b73b..a4c03eb 100644 --- a/index.js +++ b/index.js @@ -72,7 +72,7 @@ var BrowserStackBrowser = function(id, emitter, args, logger, var workerId = null; var captured = false; var log = logger.create('launcher.browserstack'); - var browserName = args.browser + (args.version ? ' ' + args.version : '') + + var browserName = (args.browser || args.device) + (args.version ? ' ' + args.version : '') + (args.os ? ' (' + args.os + ')' : '') + ' on BrowserStack'; this.id = id; @@ -82,6 +82,7 @@ var BrowserStackBrowser = function(id, emitter, args, logger, // TODO(vojta): handle non os/browser/version var settings = { os: args.os, + device: args.device, browser: args.browser, version: args.version || 'latest', url: url + '?id=' + id