From a435a8f7fd2b062966a6781b1707a566668d8ee2 Mon Sep 17 00:00:00 2001 From: Vojta Jina Date: Sun, 18 Aug 2013 17:13:44 -0700 Subject: [PATCH] fix: use browser_version as per v3 API --- README.md | 12 ++++-------- index.js | 3 ++- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index e5b8051..7c8d8fb 100644 --- a/README.md +++ b/README.md @@ -2,11 +2,6 @@ > Use any browser on [BrowserStack](http://www.browserstack.com/)! -**NOTE:** You have to run local tunnel first: -```bash -$ java -jar BrowserStackTunnel.jar localhost,9876,0 -``` - ## Installation @@ -43,9 +38,9 @@ module.exports = function(config) { bs_firefox_mac: { base: 'BrowserStack', browser: 'firefox', + browser_version: '21.0', os: 'OS X', - os_versio: 'Mountain Lion', - version: '21.0' + os_version: 'Mountain Lion' }, bs_iphone5: { base: 'BrowserStack', @@ -69,10 +64,11 @@ module.exports = function(config) { ### Per browser options - `device` name of the device - `browser` name of the browser -- `version` version of the browser +- `browser_version` version of the browser - `os` which platform ? - `os_version` version of the platform + For an example project of, check out Karma's [e2e test](https://github.com/karma-runner/karma/tree/master/test/e2e/browserstack). diff --git a/index.js b/index.js index 4f87a62..014ea10 100644 --- a/index.js +++ b/index.js @@ -85,7 +85,8 @@ var BrowserStackBrowser = function(id, emitter, args, logger, os_version: args.os_version, device: args.device, browser: args.browser, - browser_version: args.version || 'latest', + // TODO(vojta): remove "version" (only for B-C) + browser_version: args.browser_version || args.version || 'latest', url: url + '?id=' + id };