New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable popup blocking by default #9

Merged
merged 1 commit into from Dec 22, 2013

Conversation

Projects
None yet
3 participants
@axemclion
Contributor

axemclion commented Dec 9, 2013

@axemclion

This comment has been minimized.

Show comment
Hide comment
@axemclion

axemclion Dec 10, 2013

Contributor

More information about this on the Saucelab's page - https://saucelabs.com/docs/additional-config#disable-popup-handler

Contributor

axemclion commented Dec 10, 2013

More information about this on the Saucelab's page - https://saucelabs.com/docs/additional-config#disable-popup-handler

vojtajina added a commit that referenced this pull request Dec 22, 2013

Merge pull request #9 from axemclion/patch-1
feat: disable popup blocking by default

@vojtajina vojtajina merged commit cb52610 into karma-runner:master Dec 22, 2013

@vojtajina

This comment has been minimized.

Show comment
Hide comment
@vojtajina

vojtajina Dec 22, 2013

Contributor

Thanks @axemclion !

Contributor

vojtajina commented Dec 22, 2013

Thanks @axemclion !

@nateabele

This comment has been minimized.

Show comment
Hide comment
@nateabele

nateabele Mar 26, 2014

@vojtajina Is it possible to revert this without completely redefining a new Chrome runner configuration? Running the UI Router tests with this setting causes Chrome to spawn new tabs and windows until it crashes.

nateabele commented Mar 26, 2014

@vojtajina Is it possible to revert this without completely redefining a new Chrome runner configuration? Running the UI Router tests with this setting causes Chrome to spawn new tabs and windows until it crashes.

@axemclion

This comment has been minimized.

Show comment
Hide comment
@axemclion

axemclion Mar 27, 2014

Contributor

@nateabele Curious which tests are causing issues? Were all the pop-ups blocked due to Chrome only?

Contributor

axemclion commented Mar 27, 2014

@nateabele Curious which tests are causing issues? Were all the pop-ups blocked due to Chrome only?

@nateabele

This comment has been minimized.

Show comment
Hide comment
@nateabele

nateabele Mar 27, 2014

@axemclion Not 100% sure, since the window-spawning always goes haywire immediately and I have no way to launch the debugger in time, but I believe it is a problem with any test that manipulates $location. If you'd like to see it for yourself, clone https://github.com/angular-ui/ui-router, follow the dev installation instructions, and run grunt karma:debug.

nateabele commented Mar 27, 2014

@axemclion Not 100% sure, since the window-spawning always goes haywire immediately and I have no way to launch the debugger in time, but I believe it is a problem with any test that manipulates $location. If you'd like to see it for yourself, clone https://github.com/angular-ui/ui-router, follow the dev installation instructions, and run grunt karma:debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment