New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isparta instrumenter is not working with karma-coverage v0.5.0 #175

Open
martinmicunda opened this Issue Aug 17, 2015 · 17 comments

Comments

Projects
None yet
9 participants
@martinmicunda

martinmicunda commented Aug 17, 2015

I try get run isparta instrumenter with karma-coverage v0.5.0 but coverage code is still ES5 and not ES6 and my understanding is that we should not use karma-coverage fork from @douglasduteil as it mentioned in this comment by @dignifiedquire. Has anybody try isparta with karma-coverage v0.5.0? Thanks

@onlywei

This comment has been minimized.

Show comment
Hide comment
@onlywei

onlywei Sep 15, 2015

@martinmicunda I think you mean v0.5.0. I also just tried with v0.5.2 and I am still seeing ES5 and not ES6 code.

onlywei commented Sep 15, 2015

@martinmicunda I think you mean v0.5.0. I also just tried with v0.5.2 and I am still seeing ES5 and not ES6 code.

@martinmicunda

This comment has been minimized.

Show comment
Hide comment
@martinmicunda

martinmicunda Sep 15, 2015

@onlywei yeah I meant v0.5.0 and even I am running the latest v0.5.2 but the code is still ES5 and not ES6... maybe @dignifiedquire and @douglasduteil could help here?

martinmicunda commented Sep 15, 2015

@onlywei yeah I meant v0.5.0 and even I am running the latest v0.5.2 but the code is still ES5 and not ES6... maybe @dignifiedquire and @douglasduteil could help here?

@martinmicunda martinmicunda changed the title from isparta instrumenter is not working with karma-coverage v5.0.0 to isparta instrumenter is not working with karma-coverage v0.5.0 Sep 15, 2015

@martinmicunda

This comment has been minimized.

Show comment
Hide comment
@martinmicunda

martinmicunda Oct 1, 2015

@dignifiedquire @douglasduteil is there any update on this issue? Thanks

martinmicunda commented Oct 1, 2015

@dignifiedquire @douglasduteil is there any update on this issue? Thanks

@pewh

This comment has been minimized.

Show comment
Hide comment
@pewh

pewh commented Oct 21, 2015

+1

@jashatton

This comment has been minimized.

Show comment
Hide comment
@jashatton

jashatton Oct 28, 2015

@dignifiedquire @douglasduteil @martinmicunda I was hoping to get this working as well, any chance of another temporary fork, or a known workaround? Thanks

jashatton commented Oct 28, 2015

@dignifiedquire @douglasduteil @martinmicunda I was hoping to get this working as well, any chance of another temporary fork, or a known workaround? Thanks

@martinmicunda

This comment has been minimized.

Show comment
Hide comment
@martinmicunda

martinmicunda Oct 28, 2015

@jashatton I wrote a blog how to get run unit test with coverage.. Check it here

martinmicunda commented Oct 28, 2015

@jashatton I wrote a blog how to get run unit test with coverage.. Check it here

@jashatton

This comment has been minimized.

Show comment
Hide comment
@jashatton

jashatton Oct 28, 2015

@martinmicunda It is a great article, thank you for writing it. It mirrors our set up and what brought me to this issue. Did you ever get ES6 code to display in the coverage reports?

jashatton commented Oct 28, 2015

@martinmicunda It is a great article, thank you for writing it. It mirrors our set up and what brought me to this issue. Did you ever get ES6 code to display in the coverage reports?

@martinmicunda

This comment has been minimized.

Show comment
Hide comment
@martinmicunda

martinmicunda Oct 28, 2015

@jashatton yeah it mentioned in the article.. You can see ES6 coverage report here

martinmicunda commented Oct 28, 2015

@jashatton yeah it mentioned in the article.. You can see ES6 coverage report here

@jashatton

This comment has been minimized.

Show comment
Hide comment
@jashatton

jashatton Oct 28, 2015

Well, after a couple hours of reading and inferring into documentation and Stack Overflow anwsers, I figured out how to get branch versions of npm modules installed. But, I have it working now. Thanks again for the article it was the catalyst for me to learn more about npm and have readable coverage reports.

jashatton commented Oct 28, 2015

Well, after a couple hours of reading and inferring into documentation and Stack Overflow anwsers, I figured out how to get branch versions of npm modules installed. But, I have it working now. Thanks again for the article it was the catalyst for me to learn more about npm and have readable coverage reports.

@jsg2021

This comment has been minimized.

Show comment
Hide comment
@jsg2021

jsg2021 Nov 18, 2015

@jashatton what modules did you switch to branches?

jsg2021 commented Nov 18, 2015

@jashatton what modules did you switch to branches?

@onlywei

This comment has been minimized.

Show comment
Hide comment
@onlywei

onlywei Dec 16, 2015

Is there an update here?

onlywei commented Dec 16, 2015

Is there an update here?

@jashatton

This comment has been minimized.

Show comment
Hide comment
@jashatton

jashatton Dec 18, 2015

Wow, sorry I missed the notifications. I am currently using what is below in my package.json

devDependencies {
    "babel-core": "5.8.21",
    "gulp": "3.9.0",
    "gulp-jshint": "1.11.2",
    "gulp-sass": "2.0.2",
    "isparta": "3.5.0",
    "istanbul": "git+http://github.com/gotwarlost/istanbul/#source-map",
    "jasmine-core": "2.3.4",
    "jshint-stylish": "2.0.1",
    "jspm": "0.15.7",
    "karma": "0.13.9",
    "karma-babel-preprocessor": "5.2.2",
    "karma-chrome-launcher": "0.2.0",
    "karma-coverage": "git+https://github.com/douglasduteil/karma-coverage.git#next",
    "karma-jasmine": "0.3.6",
    "karma-jspm": "2.0.1-beta.1",
    "karma-junit-reporter": "0.3.8",
    "karma-ng-html2js-preprocessor": "0.2.0",
    "karma-phantomjs-launcher": "0.2.1",
    "karma-sourcemap-loader": "0.3.6",
    "phantomjs": "1.9.18",
    "shelljs": "0.5.1",
    "vinyl-source-stream": "1.1.0"
}

@jsg2021 I am referencing Github npm modules for karma-coverage and istanbul to get coverage reports that have usable sourcemaps.

If anyone could use more information certainly let me know, I will try to keep an eye out for notifications.

jashatton commented Dec 18, 2015

Wow, sorry I missed the notifications. I am currently using what is below in my package.json

devDependencies {
    "babel-core": "5.8.21",
    "gulp": "3.9.0",
    "gulp-jshint": "1.11.2",
    "gulp-sass": "2.0.2",
    "isparta": "3.5.0",
    "istanbul": "git+http://github.com/gotwarlost/istanbul/#source-map",
    "jasmine-core": "2.3.4",
    "jshint-stylish": "2.0.1",
    "jspm": "0.15.7",
    "karma": "0.13.9",
    "karma-babel-preprocessor": "5.2.2",
    "karma-chrome-launcher": "0.2.0",
    "karma-coverage": "git+https://github.com/douglasduteil/karma-coverage.git#next",
    "karma-jasmine": "0.3.6",
    "karma-jspm": "2.0.1-beta.1",
    "karma-junit-reporter": "0.3.8",
    "karma-ng-html2js-preprocessor": "0.2.0",
    "karma-phantomjs-launcher": "0.2.1",
    "karma-sourcemap-loader": "0.3.6",
    "phantomjs": "1.9.18",
    "shelljs": "0.5.1",
    "vinyl-source-stream": "1.1.0"
}

@jsg2021 I am referencing Github npm modules for karma-coverage and istanbul to get coverage reports that have usable sourcemaps.

If anyone could use more information certainly let me know, I will try to keep an eye out for notifications.

@RomanGotsiy

This comment has been minimized.

Show comment
Hide comment
@RomanGotsiy

RomanGotsiy Dec 19, 2015

Still don't work on v0.5.3
But works great with @douglasduteil's fork

RomanGotsiy commented Dec 19, 2015

Still don't work on v0.5.3
But works great with @douglasduteil's fork

@RomanGotsiy

This comment has been minimized.

Show comment
Hide comment
@RomanGotsiy

RomanGotsiy Dec 22, 2015

@blittle
$ npm install github:douglasduteil/karma-coverage#next --save-dev
does the trick.

You can check my package.json and karma.conf.js

And this is an example of my coverage results. You can see it shows ES6 code

RomanGotsiy commented Dec 22, 2015

@blittle
$ npm install github:douglasduteil/karma-coverage#next --save-dev
does the trick.

You can check my package.json and karma.conf.js

And this is an example of my coverage results. You can see it shows ES6 code

@blittle

This comment has been minimized.

Show comment
Hide comment
@blittle

blittle commented Dec 22, 2015

@RomanGotsiy Thanks!

@AdamWillden

This comment has been minimized.

Show comment
Hide comment
@AdamWillden

AdamWillden Dec 29, 2015

+1

Be great if this could be fixed. Seems that the douglasteil branch cant use the coverage check option so either way I have to lose some functionality that I want :-(

I'm assuming this is a problem with karma-coverage and not isparta?

AdamWillden commented Dec 29, 2015

+1

Be great if this could be fixed. Seems that the douglasteil branch cant use the coverage check option so either way I have to lose some functionality that I want :-(

I'm assuming this is a problem with karma-coverage and not isparta?

@otroboe

This comment has been minimized.

Show comment
Hide comment
@otroboe

otroboe commented Aug 31, 2016

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment