Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle Firefox location correctly on Windows #3

Closed

Conversation

JoeDoyle23
Copy link

Handle the differences between 32 and 64 bit Windows when building the
path to the Firefox bin

Handle the differences between 32 and 64 bit Windows when building the
path to the Firefox bin
},
ENV_CMD: 'FIREFOX_NIGHTLY_BIN'
};

FirefoxNightlyBrowser.$inject = ['id', 'baseBrowserDecorator', 'logger'];

function windowsFirefoxPath(firefoxExe) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just style:

@vojtajina
Copy link
Contributor

Same as the Chrome launcher - can you change the commit msg to just fix: handle Firefox location on Windows (remove the "firefox-launcher").

},
ENV_CMD: 'FIREFOX_NIGHTLY_BIN'
};

FirefoxNightlyBrowser.$inject = ['id', 'baseBrowserDecorator', 'logger'];

var windowsFirefoxPath = function(firefoxExe) {
var programFiles = os.arch()==='x64' ? process.env['ProgramFiles(x86)'] : process.env.ProgramFiles;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in https://github.com/karma-runner/karma-chrome-launcher/pull/3/files#L0R63 - this is an incorrect change and my solution is more future-proof: #3.

@vojtajina
Copy link
Contributor

Fixed by #9. Thanks @JoeDoyle23 .

@vojtajina vojtajina closed this Nov 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants