New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle Firefox location correctly on Windows #3

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@JoeDoyle23

JoeDoyle23 commented Aug 13, 2013

Handle the differences between 32 and 64 bit Windows when building the
path to the Firefox bin

Joe Doyle
fix(firefox-launcher): Handle Firefox location correctly on Windows
Handle the differences between 32 and 64 bit Windows when building the
path to the Firefox bin
index.js Outdated
},
ENV_CMD: 'FIREFOX_NIGHTLY_BIN'
};
FirefoxNightlyBrowser.$inject = ['id', 'baseBrowserDecorator', 'logger'];
function windowsFirefoxPath(firefoxExe) {

This comment has been minimized.

@vojtajina

vojtajina Aug 17, 2013

Contributor

just style:

@vojtajina

This comment has been minimized.

Contributor

vojtajina commented Aug 17, 2013

Same as the Chrome launcher - can you change the commit msg to just fix: handle Firefox location on Windows (remove the "firefox-launcher").

},
ENV_CMD: 'FIREFOX_NIGHTLY_BIN'
};
FirefoxNightlyBrowser.$inject = ['id', 'baseBrowserDecorator', 'logger'];
var windowsFirefoxPath = function(firefoxExe) {
var programFiles = os.arch()==='x64' ? process.env['ProgramFiles(x86)'] : process.env.ProgramFiles;

This comment has been minimized.

@mgol

mgol Sep 9, 2013

Contributor

Same comment as in https://github.com/karma-runner/karma-chrome-launcher/pull/3/files#L0R63 - this is an incorrect change and my solution is more future-proof: #3.

@vojtajina

This comment has been minimized.

Contributor

vojtajina commented Nov 22, 2013

Fixed by #9. Thanks @JoeDoyle23 .

@vojtajina vojtajina closed this Nov 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment