fix: handle Firefox location correctly on Windows #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the differences between 32 and 64 bit Windows when building the path to the Firefox bin
index.js
Outdated
Contributor
There was a problem hiding this comment.
just style:
- use the
var windowsFirefoxPath = function(...) {...syntax please ( as per http://nodeguide.com/style.html) - move the
require('os')to top of the file...
Contributor
|
Same as the Chrome launcher - can you change the commit msg to just |
Contributor
There was a problem hiding this comment.
Same comment as in https://github.com/karma-runner/karma-chrome-launcher/pull/3/files#L0R63 - this is an incorrect change and my solution is more future-proof: #3.
Contributor
|
Fixed by #9. Thanks @JoeDoyle23 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the differences between 32 and 64 bit Windows when building the
path to the Firefox bin