Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runner): extract multiline relevant message from stack completely #92

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@srrvnn
Copy link

srrvnn commented May 27, 2015

While checking for relevant messages present in step.stack, remove the "Error: "
prefix to ensure the first line of a multi line error message gets included
correctly as a relevant message, along with the other lines.

Closes #91

Saravanan Ganesh
fix(runner): extract multiline relevant message from stack completely
While checking for relevant messages present in step.stack, remove the "Error: "
prefix to ensure the first line of a multi line error message gets included
correctly as a relevant message, along with the other lines.

Closes #91
@maksimr

This comment has been minimized.

Copy link
Contributor

maksimr commented May 28, 2015

@srrvnn Thanks!!

Can you write test for this case

@srrvnn

This comment has been minimized.

Copy link
Author

srrvnn commented May 29, 2015

my bad. this is the same issue as #79. was fixed in the source here, but not in the package from npm install. it also has a corresponding test case.

closing this pull request, as this is redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.