Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of testsuite name attribute #173

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stweedie
Copy link

I added the ability to customize the testsuite name attribute using a suiteNameFormatter function. The default behavior of this setting (if no function is passed) is to use the browser's name, which is what is currently being done.

The context for this is in VSTS, test results have to be in one of a very limited set of formats, including JUnit. They pull in the name attribute on the testsuite to identify the tests. Without being able to customize suite name, the results look like this:

vsts

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@stweedie
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@SamH95
Copy link

SamH95 commented May 8, 2020

Hi, whats the status on this? I would really appreciate a feature like this.

Regards
Sam

@glenn222
Copy link

Hello, any update on this? This is a really nice feature to have in test reporting.

@testifyqa
Copy link

is anyone able to merge this please?

@jginsburgn
Copy link
Member

Thanks for pinging! Let me take a look shortly.

@doblinger-extron
Copy link

Any updates?

@ZenwalkerD
Copy link

Any body pushing this PR ? no updates on this for long time.

@jginsburgn
Copy link
Member

PRs are currently blocked by: #190. I hope it can be resolved soon!

@patrickhuy
Copy link

Hey @jginsburgn any updates on this? Would it help to get this merged and released if one were to help out on #190? Do you have requirements on what you want for #190?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants