Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent fatal error when browser failed to start #21

Closed
wants to merge 1 commit into from
Closed

fix: prevent fatal error when browser failed to start #21

wants to merge 1 commit into from

Conversation

syavorsky
Copy link

fixes #20

This is just a workaround, I guess onBrowserComplete normally should never be called multiple times for same browser. Grunt won't fail at least if it happens so.

@vojtajina
Copy link
Contributor

Thanks @yavorskiy. Do you understand how can this happen? I would much rather fix this in Karma than working it around in the reporter.

@vojtajina
Copy link
Contributor

It looks like it's related to the syntax error. If there is an error during loading a file, Karma should report error() and complete() and not even start the run. For some reason it does start the run and calls complete twice.

@syavorsky
Copy link
Author

@vojtajina right that's exactly the reason why. I agree junit reporter is not the right place to fix, but am not sure I can track it down in karma. It's fine if you just decline this PR

@eggers
Copy link

eggers commented Oct 21, 2014

This is an annoying bug for us. Can we get this merged in if it does fix the problem, even if the root problem is in karma?

@j0tunn
Copy link

j0tunn commented Nov 12, 2014

Any progress on this PR? I think it should be merged: no matter what caused the problem, the problem is here

@dignifiedquire
Copy link
Member

Fixed in karma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal error: Cannot read property %browser.id% of null
5 participants