Add phantomjs-prebuilt to dependency list

[joelmukuthu]

In order to have it automatically installed as a peer dependency in
npm@3 as well as in npm@2.

Closes #104

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[joelmukuthu]

I signed it!

[googlebot]

CLAs look good, thanks!

[joelmukuthu]

Ping @dignifiedquire / @zzo. From #104 it seems that more and more people are experiencing this issue, is this an acceptable solution to you?

[zzo]

i think you can take it out of peerDeps and devDeps if it's blatantly in the deps list. But this solution seems legit.
Also update the commit message to match https://karma-runner.github.io/0.13/dev/git-commit-msg.html

[joelmukuthu]

I would have argued to keep it in peerDependencies (for the sake of npm2 users) but since the desired end result is to have a phantomjs binary in ./node_modules/.bin/, I agree with that solution. I will update my commit and force-push.

[CarmenPopoviciu]

anything I can help with to have this merged in? Would gladly help out ^_^

[zzo]

v1.0.1 released to npm with this

[CarmenPopoviciu]

@zzo you sir are awesome! Thank you for all the great work you are doing. And thank you @joelmukuthu for fixing the issue.

[dignifiedquire]

@zzo why did you merge this? This forces everyone using phantom 1 to install phantom 2 even if they don't need it. Before you simply installed the correct version side by side (given npm@3) and for npm@2 it would install it together.

[zzo]

without phantom this fails and disk is cheap :)
Seriously maybe this should have been a bigger version jump but if they don't want phantom/know what they are doing they can pin to the previous version. perhaps this instead could be a post-install hook, if phantom is not present then install it.

[dignifiedquire]

Disk space yes, bandwith often is slow and expensive :(

[CarmenPopoviciu]

I dug a bit deeper into the repo history, because I wanted to better understand your concerns, and found the issue that moved phantomjs to peerDependencies. I also checked the npm GH discussion related to the changed behaviour of peerDependencies for npm3, which helped me understand much better the intention behind their move and what the expected course of actions in case of conflicts is.

Apparently the solution for #104 was indeed installing phantomjs-prebuilt manually, as per npm peerDependencies conflict management. Things probably broke because the module was renamed and since it's explicitly required by the code(which made me wonder if this is indeed a good fit for peerDeps), that made any previous local phantom installations incompatible.