From 17f94f8601463f1dddc587e20fd98c786f2165a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johannes=20Wu=CC=88rbach?= Date: Sun, 14 Jul 2013 16:12:42 +0200 Subject: [PATCH] fix: shut down sauce connect properly Closes #5 --- index.js | 9 ++------- package.json | 2 +- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/index.js b/index.js index 9c80e65..2eba51b 100644 --- a/index.js +++ b/index.js @@ -32,10 +32,6 @@ var SauceConnect = function(emitter, logger) { alreadyRunningDefered = q.defer(); launchSauceConnect(options, function(err, p) { - if (onKilled) { - return onKilled(); - } - alreadyRunningProces = p; alreadyRunningDefered.resolve(); }); @@ -46,8 +42,7 @@ var SauceConnect = function(emitter, logger) { emitter.on('exit', function(done) { if (alreadyRunningProces) { log.info('Shutting down Sauce Connect'); - onKilled = done; - alreadyRunningProces.close(); + alreadyRunningProces.close(done); } else { done(); } @@ -103,7 +98,7 @@ var SauceLabsBrowser = function(id, args, sauceConnect, /* config.sauceLabs */ c 'build': args.build || config.build || process.env.TRAVIS_BUILD_NUMBER || process.env.BUILD_NUMBER || process.env.BUILD_TAG || process.env.CIRCLE_BUILD_NUM || null - + }; url = url + '?id=' + id; diff --git a/package.json b/package.json index 06de4b9..2d9a8e0 100644 --- a/package.json +++ b/package.json @@ -20,7 +20,7 @@ "author": "Vojta Jina ", "dependencies": { "wd": "~0.0.32", - "sauce-connect-launcher": "~0.1.5", + "sauce-connect-launcher": "~0.1.10", "q": "~0.9.6" }, "peerDependencies": {