From c2968a0c75d163cde96f032c89f0b7efde27c25f Mon Sep 17 00:00:00 2001 From: Vojta Jina Date: Sun, 24 Nov 2013 20:57:57 -0800 Subject: [PATCH] feat: allow "options" that are applied to all browsers --- index.js | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/index.js b/index.js index d504fc9..7a2d54d 100644 --- a/index.js +++ b/index.js @@ -49,7 +49,7 @@ var SauceConnect = function(emitter, logger) { }; -var SauceLabsBrowser = function(id, args, sauceConnect, /* config.sauceLabs */ config, logger, emitter) { +var SauceLabsBrowser = function(id, args, sauceConnect, /* config.sauceLabs */ config, logger, emitter, helper) { config = config || {}; var username = process.env.SAUCE_USERNAME || args.username || config.username; @@ -85,7 +85,7 @@ var SauceLabsBrowser = function(id, args, sauceConnect, /* config.sauceLabs */ c }; var start = function(url) { - var options = { + var options = helper.merge(config.options, args, { browserName: args.browserName, version: args.version || '', platform: args.platform || 'ANY', @@ -98,13 +98,7 @@ var SauceLabsBrowser = function(id, args, sauceConnect, /* config.sauceLabs */ c process.env.BUILD_NUMBER || process.env.BUILD_TAG || process.env.CIRCLE_BUILD_NUM || null, 'device-orientation': args.deviceOrientation || null - }; - - for (var key in args) { - if (!options.hasOwnProperty(key)) { - options[key] = args[key]; - } - } + }); url = url + '?id=' + id;