feat: disable popup blocking by default #16

Merged
merged 1 commit into from Dec 24, 2013

Conversation

Projects
None yet
2 participants
@axemclion
Contributor

axemclion commented Dec 10, 2013

Disabling Saucelab's Popup blocker, as described here - https://saucelabs.com/docs/additional-config#disable-popup-handler.

Note that the browser's flags would have still be set.

@vojtajina

This comment has been minimized.

Show comment
Hide comment
@vojtajina

vojtajina Dec 22, 2013

Contributor

What does this do?

Contributor

vojtajina commented Dec 22, 2013

What does this do?

@axemclion

This comment has been minimized.

Show comment
Hide comment
@axemclion

axemclion Dec 22, 2013

Contributor

Apparently, Saucelabs has another popup blocker installed

Sauce has its own Popup killer that automatically clicks through some types of browser popup windows, to let > tests continue. By default, this feature is turned on for Selenium 1 and off for Selenium 2 tests. You can control > the popup handler yourself with the following capability

This is required for disabling that.

Contributor

axemclion commented Dec 22, 2013

Apparently, Saucelabs has another popup blocker installed

Sauce has its own Popup killer that automatically clicks through some types of browser popup windows, to let > tests continue. By default, this feature is turned on for Selenium 1 and off for Selenium 2 tests. You can control > the popup handler yourself with the following capability

This is required for disabling that.

vojtajina added a commit that referenced this pull request Dec 24, 2013

Merge pull request #16 from axemclion/master
feat: disable popup blocking by default

@vojtajina vojtajina merged commit 7033712 into karma-runner:master Dec 24, 2013

@vojtajina

This comment has been minimized.

Show comment
Hide comment
@vojtajina

vojtajina Dec 24, 2013

Contributor

Cool, thanks @axemclion !

Contributor

vojtajina commented Dec 24, 2013

Cool, thanks @axemclion !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment