From 5ee886bc16fc5a2bd08101d351027345530f87df Mon Sep 17 00:00:00 2001 From: Vojta Jina Date: Mon, 2 Dec 2013 23:30:11 -0800 Subject: [PATCH] feat(web-server): disable gzip compression With big files, the gzip compression is causing to serve only parts (chunks) of a file, as browser probably cancels the request at some timeout. See https://github.com/karma-runner/karma/pull/778 for a discussion. I saw similar issues on AngularJS build couple of times too. Doing gzip compression on the fly is not a good idea. The compress module is more likely to be removed from express/connect. If we wanna do gzip compression, we should probably do it as a preprocessor, so that it happens only once per file. --- lib/web-server.js | 8 -------- 1 file changed, 8 deletions(-) diff --git a/lib/web-server.js b/lib/web-server.js index aa16d2493..03d00ef85 100644 --- a/lib/web-server.js +++ b/lib/web-server.js @@ -42,17 +42,9 @@ var createWebServer = function(injector, emitter) { filesPromise: ['value', filesPromise] }]); - // TODO(vojta): remove if https://github.com/senchalabs/connect/pull/850 gets merged - var compressOptions = { - filter: function(req, res){ - return (/json|text|javascript|dart/).test(res.getHeader('Content-Type')); - } - }; - var proxyMiddlewareInstance = injector.invoke(proxyMiddleware.create); var handler = connect() - .use(connect.compress(compressOptions)) .use(injector.invoke(runnerMiddleware.create)) .use(injector.invoke(karmaMiddleware.create)) .use(injector.invoke(sourceFilesMiddleware.create))