refactor(server): refactor bundleResource in lib/server.js

[lusarz]

Pull request refactor code around static/context.js and static/karma.js bundling. Main changes:

• move code responsible for bundle resources with browserify into lib/utils/bundle-utils
• move responsibility to check if bundled files exists into BundleUtils.bundleResourceIfNotExist method
• overall refactoring
• adding unit tests for created methods

[lusarz]

Moved responsibility to check if outPath file already exists to bundleResource method.

[johnjbarton]

Please put this comment in the git commit description.

[lusarz]

You mean pull request description ?

[lusarz]

This whole else block was actually not covered by unit tests.

[johnjbarton]

So this test does not work?

karma/test/unit/server.spec.js

Line 113 in 31d9a08

it('should compile static resources on first run', function (done) {

[lusarz]

Sorry, I was in a hurry. True, this test covers bundleResource invoke in else block, but it was possible to remove this line:

karma/lib/server.js

Line 181 in 642b177

.then(startWebServer)

and no unit test fails

[johnjbarton]

Now that I look more carefully the else case test is not correct because fs is not injected and the test runs in the same filesystem location every time. If the file system has the static files from a previous run or from a use of karma the test will pass even if bundling code does not work.

[lusarz]

I've updated it a bit, now everything should be tested.

[johnjbarton]

Please put this comment in the git commit description.

[johnjbarton]

I think the code would be clearer if you create function to compute the paths:

  bundleResource(['/../client/main.js', '/../static/karma.js'].map(absPath));

If you also pass the fs:

  bundleResource(fs, ['/../client/main.js', '/../static/karma.js'].map(absPath));

then we can unit test the bundleResource() properly.

[lusarz]

Maybe a bit other way, but done :)

[johnjbarton]

Thanks!